Skip to content

Conversation

@simoniz0r
Copy link
Contributor

Build AppImages from deb packages on any distro with simple json configuration

Build AppImages from deb packages on any distro with simple json configuration
@simoniz0r
Copy link
Contributor Author

Looks ok to merge?

@probonopd
Copy link
Member

probonopd commented Mar 11, 2018

Not really, because for whatever reason the files that are supposed to be extracted automatically don't show up in https://github.com/AppImage/appimage.github.io/pull/445/files. The reason for this needs to be investigated. I am not saying it's your fault...

@simoniz0r
Copy link
Contributor Author

Oh, yay, still that problem.

@simoniz0r
Copy link
Contributor Author

simoniz0r commented Mar 12, 2018

@probonopd this is why it's failing:

 if [ -e database/$INPUTBASENAME/*.desktop ] ; then

image

You cannot use the * like that. Something like this should work:

EDITED (previous command never failed; this is more reliable):

if [ -f "database/$INPUTBASENAME/$(dir -C -w 1 database/$INPUTBASENAME | grep -m1 '.desktop')" ]; then

Also, you should be putting double quotes around things like this to prevent errors:

 if [ -e database/$INPUTBASENAME/appdata.yaml ] ; then

Should be changed to:

 if [ -e "database/$INPUTBASENAME/appdata.yaml" ] ; then

@simoniz0r
Copy link
Contributor Author

3 files changed, 57 insertions(+)
 create mode 100644 apps/deb2appimage.md
 create mode 100644 database/deb2appimage/deb2appimage.desktop
 create mode 100644 database/deb2appimage/screenshot.png
+set +x
+git push --set-upstream deploy
fatal: You are not currently on a branch.
To push the history leading to the current (detached HEAD)
state now, use
    git push deploy HEAD:<name-of-remote-branch>

@probonopd
Copy link
Member

Seems to be similar to #239 (comment)

@simoniz0r simoniz0r closed this Mar 31, 2018
@simoniz0r simoniz0r deleted the patch-1 branch March 31, 2018 08:22
@probonopd
Copy link
Member

Please reopen this PR as the issue might be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants