Skip to content

fix: feedback MCP tool schema says 'rating' but handler expects 'quality' #320

@CalebisGross

Description

@CalebisGross

Problem

The feedback tool definition in internal/mcp/tools.go defines the parameter as rating, but handleFeedback in server.go reads the field quality. This causes a confusing round-trip:

  1. Agent calls feedback({rating: "helpful"}) per the schema
  2. Handler returns error: "quality parameter is required"
  3. Agent has to guess the correct param name

Fix

Either rename the schema param from rating to quality, or update the handler to accept rating. Schema should match handler.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions