fix: prevent dismissed pattern reactivation + filter exclude_concepts on patterns#324
Merged
CalebisGross merged 1 commit intomainfrom Mar 21, 2026
Merged
fix: prevent dismissed pattern reactivation + filter exclude_concepts on patterns#324CalebisGross merged 1 commit intomainfrom
CalebisGross merged 1 commit intomainfrom
Conversation
…er exclude_concepts on patterns/principles #319: UpdatePattern now includes `WHERE state != 'archived'` guard so consolidation cycles cannot overwrite a user-dismissed pattern back to active. Silent no-op when the pattern exists but is archived. #318: exclude_concepts on recall now filters patterns and abstractions in addition to memories. Uses the same conceptOverlap helper. Closes #318, closes #319 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdatePatternnow guards withWHERE state != 'archived'so consolidation cycles can't overwrite a user-dismissed pattern back to active. Root cause: consolidation reads patterns, updates strength, and writes back the full struct — overwriting any state change made between the read and write.exclude_conceptsonrecallnow filters patterns and abstractions in addition to memories, using the sameconceptOverlaphelper.Also closed #320 (feedback schema mismatch) — was a stale tool metadata cache in Claude Code, not a code bug.
Test plan
go test ./...all passingrecallwithexclude_concepts: ["training"]no longer shows training patternsCloses #318, closes #319
🤖 Generated with Claude Code