Skip to content

blueprint: Add support for blueprint fabric-addressing-policy API#41

Merged
that1guy15 merged 4 commits intoApstra:mainfrom
shun159:feature/blueprint_fabric_addressing_policy
Nov 10, 2022
Merged

blueprint: Add support for blueprint fabric-addressing-policy API#41
that1guy15 merged 4 commits intoApstra:mainfrom
shun159:feature/blueprint_fabric_addressing_policy

Conversation

@shun159
Copy link
Copy Markdown
Contributor

@shun159 shun159 commented Oct 31, 2022

Add support for blueprint fabric-addressing-policy API.
For the details for the API, please refer to /api/blueprints/{blueprint_id}/fabric-addressing-policy on Apstra REST API Explorer.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 31, 2022

CLA assistant check
All committers have signed the CLA.

@that1guy15
Copy link
Copy Markdown
Contributor

Thanks for the contribution.
Please add test coverage to tests/test_blueprint.py for all new logic.

@shun159
Copy link
Copy Markdown
Contributor Author

shun159 commented Oct 31, 2022

@that1guy15
Hi! Thank you for your review. I have added unit test cases for the new functions.

@that1guy15
Copy link
Copy Markdown
Contributor

please address failed liniting and tests. Also make sure to update version number in setup

Copy link
Copy Markdown
Contributor

@that1guy15 that1guy15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting and tests fail in actions.
version number needs to be updated.

@shun159 shun159 requested a review from that1guy15 November 5, 2022 07:13
@shun159
Copy link
Copy Markdown
Contributor Author

shun159 commented Nov 8, 2022

Hi I have fixed for the request.

Copy link
Copy Markdown
Contributor

@that1guy15 that1guy15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants