Bugfix - fix condition for apply_configlet() in blueprint.py#43
Merged
that1guy15 merged 7 commits intoApstra:mainfrom Dec 6, 2022
Merged
Conversation
Contributor
|
Please address failed tests and linting. |
that1guy15
suggested changes
Nov 10, 2022
Contributor
that1guy15
left a comment
that1guy15
left a comment
There was a problem hiding this comment.
Fix testing and linting failures and bump version number.
Contributor
Author
|
fixed. I also bumped the version for #41 following semvar guidelines |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current method causes the condition to render incorrectly in both apstra 4.0 and 4.1 GUI.
This is because the condition pushed by the library uses single quote but apstra expects double quote in the payload.
This is caused when the library converts the role/id list into a string by using fstrings, which by default renders lists with a single quote.
The screenshot is for 4.1, but 4.0 also shows a similar issue.
With a simple replace of single quote with double quote, the condition renders correctly in apstra