Skip to content

Numpy version #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bradley-erickson merged 9 commits into from
Dec 16, 2024
Merged

Numpy version #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1a419f4
Updated numpy dependency
duckduckdoof Nov 7, 2024
dd662ff
Merge branch 'main' of github.com:ArgLab/AWE_Components
duckduckdoof Nov 7, 2024
b80deba
Updated reference to lexica
duckduckdoof Nov 7, 2024
54fade6
Locked torch version
duckduckdoof Nov 7, 2024
31b8945
Removed holmes dependency
duckduckdoof Nov 7, 2024
9572ace
Added TODO for numpy version locking
duckduckdoof Nov 21, 2024
1da1ad2
Fixed version in comment
duckduckdoof Nov 21, 2024
b1ec281
Fixed version typo
duckduckdoof Dec 6, 2024
6532224
Added websocket version lock
duckduckdoof Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions awe_components/setup/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
#!/usr/bin/env python3
# Copyright 2022, Educational Testing Service

# TODO: using numpy>1.26.4 seems to cause errors when installing from awe_workbench.
# This is related to the desired model (subwordbert) that we use for AWE.
# Version-locking seems to keep this from failing.
from spacy.cli.download import download
import os

Expand Down
9 changes: 4 additions & 5 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,27 +31,26 @@ python_requires = >=3.9
cmdclass =
install = install.AWEInstall
install_requires =
awe_lexica
awe_lexica @ git+https://github.com/ArgLab/AWE_Lexica.git
spacy
holmes_extractor
coreferee
rdflib
spacytextblob
numpy
numpy==1.26.4
Copy link
Copy Markdown

@bradley-erickson bradley-erickson Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm reluctant to add version locking here without knowing where the code breaks. Have we figured out why we need both this and the torch version lock?
Ideally, we don't have to lock either and we just fix the code that is breaking.

srsly
wordfreq
statistics
scipy
scikit-learn
nltk
aenum
websockets
websockets<14
websocket-client
pytest
clint
pygtrie
transformers
torch
torch==2.4.1
Path
[options.package_data]
* = *.cfg, *.csv, *.json, *.txt