Numpy version#6
Conversation
| rdflib | ||
| spacytextblob | ||
| numpy | ||
| numpy==1.26.4 |
There was a problem hiding this comment.
I'm reluctant to add version locking here without knowing where the code breaks. Have we figured out why we need both this and the torch version lock?
Ideally, we don't have to lock either and we just fix the code that is breaking.
|
|
I was able to track down the errors which originally caused me to revert the numpy version, but it's more confusing that I thought: Components is what installs numpy, but the issue is invoked after trying the |
|
I'm not sure - referencing #6 (comment) - if there is a specific place in Components I can comment the proper TODO? |
| #!/usr/bin/env python3 | ||
| # Copyright 2022, Educational Testing Service | ||
|
|
||
| # TODO: using numpy>1.21.4 seems to cause errors when installing from awe_workbench. |
There was a problem hiding this comment.
The version lock is 1.26.4. Is this just a typo?
There was a problem hiding this comment.
Is this the correct spot for this comment? I thought it had to do with the model we are using. So this comment ought to be placed where the model is loaded in. A quick search in the codebase makes me think it belongs in awe_components/wordprobs/wordProbabilityInContext.py; however, this may not be the correct spot for it.
There was a problem hiding this comment.
The version lock is
1.26.4. Is this just a typo?
Yup! I'll fix that.
Is this the correct spot for this comment? I thought it had to do with the model we are using. So this comment ought to be placed where the model is loaded in. A quick search in the codebase makes me think it belongs in
awe_components/wordprobs/wordProbabilityInContext.py; however, this may not be the correct spot for it.
From what I remember about the errors I was getting, it was referencing the spacy.cli.download import in data.py. I'll look at awe_components/wordprobs/wordProbabilityInContext.py nonetheless, but I think my comment is in the right place.
* Updated numpy dependency * Updated reference to lexica * Locked torch version * Removed holmes dependency * Added TODO for numpy version locking * Fixed version in comment * Fixed version typo * Added websocket version lock
* updated install data path * added find packages flag to setup * added function to download so we can call it from code if needed * Updated numpy dependency * Updated reference to lexica * Numpy version (#6) * Updated numpy dependency * Updated reference to lexica * Locked torch version * Removed holmes dependency * Added TODO for numpy version locking * Fixed version in comment * Fixed version typo * Added websocket version lock * textblob features hotfix * Added spacytextblob doc feature name fix * Added blob * Added changes to config for testing * Removed unnecessary dependencies, cleaned up existing * Removed more unnecessary imports, fixed other import issues * Removed even moar dependency issues, cleaned up imports * Added back missing error imports, fixed variable decl * Removed deprecated nameof * Removed pesky import * Removed branch for lexica * Updated readme on installation * updated readme and setup with ets specific urls * Update setup.cfg --------- Co-authored-by: duckduckdoof <duckduckdoof@gmail.com>
Added numpy version lock -- installing AWE_Workbench causes an installation issue when pulling model data. Also updates lexica dependency.