Testing (without holmes) by duckduckdoof · Pull Request #12 · ArgLab/AWE_Workbench

duckduckdoof · 2024-09-23T19:22:50Z

Changes involve:

Moving outdated tests to an "old_tests" directory (we could just delete them)
Updating the main test test_awe_nlp_no_holmes.py to not include holmes
Various formatting changes for things like parserServer.py
Removing holmes as a dependency in the repo config
Adding a few new installation scripts.

…testing_fixes

…no-holmes

Batch summary fixes

bradley-erickson · 2024-10-28T14:26:42Z

Remove this if we don't need it.

bradley-erickson · 2024-10-28T14:26:56Z

Do we need this entire directory?

bradley-erickson · 2024-10-28T14:31:31Z

+# AWE Workbench Install Script Template
+# Author: Caleb Scott
+
+# This script shows how to use the command-line arguments for the fresh_install.sh scripts.


The cases below could be further defined. I'm not really sure I follow the different cases. Additinoally, I see conda which is a little bit of a red-flag as the normal build process for the Learning Observer uses pip.

bradley-erickson · 2024-10-28T14:33:34Z

+
+echo "============================ WARNING =============================="
+echo "\nYou are about to install AWE on this system."
+echo "\n* Ensure that you are using a python3.12 version."


Is Python 3.12 a requirement for this?

bradley-erickson · 2024-10-28T14:35:05Z

This file looks super similar to venv_fresh_install.sh. How do they differ from one another? How do I know which one to use? Do I have to use conda for installation?

bradley-erickson · 2024-10-28T14:37:34Z

+
+Set of corresponding tests for document features found in awe_nlp.py of writingobserver.
+
+Author: Caleb Scott (cwscott3@ncsu.edu)


All the other files in this directory are moved from the tests to here. I assume these are all to be deleted. Why does this file show changes instead of a move as well? Will we still be using this file?
The file being in old_tests makes me assume it should be deleted, which is causing some confusion.

bradley-erickson · 2024-10-28T14:40:06Z

+-----------------------------------------------------------------------------------------
+"""
+
+# --- [ IMPORTS ] -----------------------------------------------------------------------


I'm not really the biggest fan of these types of comments. I understand that it helps break up the code a little bit, but especially in smaller files, I don't see the need for them. Even in large files, the code already does this to some degree (all the imports say import or from ... import, all the classes start with class, etc.).

bradley-erickson · 2024-11-06T15:22:03Z

This needs documentation on how to install and run tests. Much of the original documentation is not very clean (no code-blocks for commands and a bunch of unneeded =s).

I tried to go and test this code to make sure it works on my machine as well and immediately ran into issues regarding installation. The requirements.txt file specifies awe_languagetool which I know where to find and install, but pip does not. For the additional AWE items, we should specify them similar to how its specified in Learning Observer.

AWE_SpellCorrect @ git+https://github.com/ETS-Next-Gen/AWE_SpellCorrect.git
AWE_Components @ git+https://github.com/ETS-Next-Gen/AWE_Components.git
AWE_Lexica @ git+https://github.com/ETS-Next-Gen/AWE_Lexica.git
AWE_LanguageTool @ git+https://github.com/ETS-Next-Gen/AWE_LanguageTool.git

duckduckdoof · 2024-11-07T21:00:39Z

Yeah tbh I'm not sure why the requirements.txt file and setup.cfg are both there; the installation of Workbench doesn't explicitly refer to the former. Currently working to resolve those dependencies.

Additionally, a numpy update has stopped the python -m awe_workbench.setup.data from working... I've added a version lock and PR in AWE_Components (ArgLab/AWE_Components#6).

removed branch designations

bradley-erickson · 2024-11-18T21:54:30Z

Whenever I try to install the workbench, it winds up checking a bunch of different spacy versions. The download and installation of each one takes a bit (which heavily adds up over time). This should be investigated so the installation immediately installs an appropriate version.

bradley-erickson · 2024-12-01T17:06:40Z

@duckduckdoof any update on the spacy versioning? Do you also experience this when running pip install .?

duckduckdoof · 2024-12-06T16:03:44Z

@duckduckdoof any update on the spacy versioning? Do you also experience this when running pip install .?

I went ahead and tried a fresh install of workbench on a new python environment -- I only saw it attempt to install spacy3.8.2 first, then 3.5.4:

Of course, this may be quick because it's going for my cached versions? Should I elevate the verbosity to see if it's running through more than this?

bradley-erickson · 2024-12-09T20:40:14Z

I assume its also iterating through my cached versions of spacy to find one that works, but we ought to just have it install the one it needs from the get go.

bradley-erickson · 2024-12-09T21:14:27Z

-aenum
-statistics
-srsly
+awe_languagetool @ git+https://github.com/ArgLab/AWE_LanguageTool.git


Do we need this file? Everything should probably be in the setup.cfg file instead for easier installation.

… test-no-holmes

* Added gitignore * Removed typo * Added missing test for lexical features * consolidated AWE_Info declarations for better readability * Added AWE_NLP tests from WO * Fixed typo * Added install script for conda * Updated install script * Updated install script * Added protobuf patch * Added baseline tests for WritingObserver * Updated gitignore * Added install scripts for conda and venv envs * Cleaned install scripts * Moved old tests, updated web files * Updated main test to work without holmes * Updated main test, added essay 'chooser' * Updated essay 'chooser' * Updates to parserServer * Updated parserServer stubs & pipeline * Removed coreferee from test; covered in pipeline.py * No-holmes baseline tests * Updated modules * Removed holmes dependency * Removed git conflict text * Attempted removal of holmes from parserServer.py * attempting removal of holmes from parserServer * refactored to (mostly) use a local dict for document storage * refactored to (mostly) use a local dict for document storage * Update parserServer.py * Update batch_summary.py Added synchronization to batchSummary to make merging dataframes work right * no meaningful changes, just removed unused imports * Removed unecessary files * Updated test name; requirements; docs * Update old requirements * Removed lexica to install; components already does this * Removed old parser server code * Update setup.cfg removed branch designations * Removed requirements in favor of setup.cfg --------- Co-authored-by: Caleb Scott <goose@the-pond-11.lan> Co-authored-by: cwscott3 <cwscott3@ncsu.edu> Co-authored-by: arsalaan <arsalaankhan022@gmail.com> Co-authored-by: askhan6 <askhan6@ncsu.edu> Co-authored-by: ArsalaanK7 <132946619+ArsalaanK7@users.noreply.github.com>

duckduckdoof and others added 28 commits May 17, 2024 10:50

Added gitignore

d558337

Removed typo

651b926

Added missing test for lexical features

ca744c4

consolidated AWE_Info declarations for better readability

d925712

Added AWE_NLP tests from WO

cda6a1a

Fixed typo

3922774

Added install script for conda

1dd2b70

Updated install script

9770521

Updated install script

3207924

Merge branch 'testing_fixes' of github.com:ArgLab/AWE_Workbench into …

ec1d97e

…testing_fixes

Added protobuf patch

a820c8f

Added baseline tests for WritingObserver

43c6975

Updated gitignore

b2d74fb

Added install scripts for conda and venv envs

07f8f73

Merge branch 'fresh-install' of github.com:ArgLab/AWE_Workbench into …

fa66594

…no-holmes

Cleaned install scripts

c782c2d

Moved old tests, updated web files

6e9f1be

Updated main test to work without holmes

6cdf48b

Updated main test, added essay 'chooser'

c4165be

Updated essay 'chooser'

e46b58e

Updates to parserServer

4c643a8

Updated parserServer stubs & pipeline

468988b

Removed coreferee from test; covered in pipeline.py

d07625a

No-holmes baseline tests

c887a47

Updated modules

ff480f3

Fixed merge issues

da42c9e

Removed holmes dependency

1c36ade

Removed git conflict text

7e9b8db

duckduckdoof requested review from DrLynch and bradley-erickson September 23, 2024 19:22

duckduckdoof and others added 2 commits October 24, 2024 17:41

Merge pull request #13 from ArgLab/batchSummary-fixes

dcca251

Batch summary fixes

no meaningful changes, just removed unused imports

ca93d0f

bradley-erickson reviewed Oct 28, 2024

View reviewed changes

Comment thread awe_workbench/web/oldParserServer.py Outdated

Copy link
Copy Markdown

bradley-erickson Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this if we don't need it.

bradley-erickson reviewed Oct 28, 2024

View reviewed changes

Comment thread tests/old_tests/__init__.py Outdated

Copy link
Copy Markdown

bradley-erickson Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this entire directory?

bradley-erickson reviewed Oct 28, 2024

View reviewed changes

Removed unecessary files

12e2c8a

duckduckdoof requested a review from bradley-erickson October 31, 2024 21:48

duckduckdoof added 2 commits November 7, 2024 15:16

Updated test name; requirements; docs

826f93e

Update old requirements

db9ca1e

Removed lexica to install; components already does this

1328501

bradley-erickson reviewed Nov 7, 2024

View reviewed changes

Comment thread setup.cfg

duckduckdoof added 2 commits November 14, 2024 21:02

Removed old parser server code

f55cd56

Update setup.cfg

77df65d

removed branch designations

bradley-erickson reviewed Dec 9, 2024

View reviewed changes

duckduckdoof added 2 commits December 19, 2024 11:06

Removed requirements in favor of setup.cfg

2676cad

Merge branch 'test-no-holmes' of github.com:ArgLab/AWE_Workbench into…

1e5c2a5

… test-no-holmes

bradley-erickson approved these changes Jan 7, 2025

View reviewed changes

bradley-erickson merged commit a7a686b into main Jan 7, 2025

duckduckdoof mentioned this pull request Jan 16, 2025

Document feature documentation #16

Closed


		Set of corresponding tests for document features found in awe_nlp.py of writingobserver.

		Author: Caleb Scott (cwscott3@ncsu.edu)

Conversation

duckduckdoof commented Sep 23, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bradley-erickson commented Nov 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

duckduckdoof commented Nov 7, 2024

Uh oh!

Uh oh!

bradley-erickson commented Nov 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bradley-erickson commented Dec 1, 2024

Uh oh!

duckduckdoof commented Dec 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bradley-erickson commented Dec 9, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bradley-erickson commented Nov 6, 2024 •

edited

Loading

bradley-erickson commented Nov 18, 2024 •

edited

Loading

duckduckdoof commented Dec 6, 2024 •

edited

Loading