Decouple Array<T> from ArrayBufferView #1121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After wasting a lot of time trying to refactor ArrayBufferView incl. updating all of stdlib, tests and the compiler internals at once, this PR just implements the bare minimum of changes to decouple
Array<T>from theArrayBufferViewinterface as a basis.This keeps
dataStartfor now on both ABVs and Array, since updating it tobuffer + byteOffsetturned out to have just so many implications, especially wheredataStartis used to obtain unsafe pointers, that spotting any problems introduced by refactoring became nearly impossible.Based on that I suggest to first replace those usages of
dataStartin stdlib and tests with a newFixedArrayconcept as discussed on Slack, and only then continue from there.Supersedes #1112