Fix ArrayBufferView interface #1112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Perhaps a better strategy would be to make |
Member
|
Yeah agree, we discussed about this in the past btw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a change a while ago that tried to unify the
ArrayBufferViewinterface, but it turned out that the changes there are unsafe. In particular:Array<T>must not expose.buffersince it can resize automatically, leading to use-after-free scenarios in the worst case.Array<T>does not have a.byteLengthproperty.The only sensible solution there is to use distinct
@unsafefields for the ABV interface, with actual implementations providing safe getters.Original breaking PR: #865
Related docs issue: https://github.com/AssemblyScript/docs/pull/7