Refactor ArrayBufferView

[MaxGraey]

No description provided.

[dcodeIO]

LGTM :) Might be a good opportunity to also think about the dataStart name, which somewhat made sense while there was data and dataLength, but now is a bit unintuitive. I don't have a good idea for a better name, though.

[MaxGraey]

I guess better leave old name for dataStart because it's already used a lot in external third-party source codes. Also it's unsafe and don't use in safe-context which I guess will be standard de-facto in future.

[dcodeIO]

There is a chance that removing data and dataLength breaks these cases anyway, hence the suggestion. Isn't super important to rename it ofc, but if we want to do it I'd say that this is the PR - or we'll never do it :)

[MaxGraey]

Yeah. We could add something like:

class ArrayBufferView {
  ...
  @unsafe readonly rawBuffer: usize;
  ...

  @inline function dataStart(): usize {
    WARNING("dataStart was deprecated. Please use 'rawBuffer' instead");
    return this.rawBuffer;
  }
}

[MaxGraey]

@dcodeIO what about rawBuffer?

[dcodeIO]

Thinking about it a little more, it's "the unsafe pointer to the start of the data in the backing buffer", so dataStart isn't that bad maybe, with only dataStartPtr or maybe a short unsafePtr being more concise but perhaps not worth the trouble I guess.

[dcodeIO]

Thanks!