Skip to content

Conversation

@willemneal
Copy link
Contributor

@willemneal willemneal commented Mar 17, 2021

It is compared to a usize later and used as one later.

  • I've read the contributing guidelines

It is compared to a usize later and used as one later.
@willemneal
Copy link
Contributor Author

@dcodeIO I reverted back to isize and adding casting to the comparison. I added a line to the wasi tests, but locally it reported that it was skipped due to big int integration. Is there a way to not skip the test? Is it still compiled when skipped?

@dcodeIO
Copy link
Member

dcodeIO commented Mar 19, 2021

The mechanism to enable certain features in the test suite is setting the ASC_FEATURES environment variable. One can set it to a comma separated list of features (see tests/features.json), or just * to enable all features. CI runs a subset of them in the "Features" job. If a feature is not enabled, affected tests are skipped fully, including when compiling to/updating fixtures.

@willemneal
Copy link
Contributor Author

@dcodeIO I added std-wasi/process and std-wasi/crypto to the features CI test.

@willemneal willemneal requested a review from dcodeIO March 22, 2021 13:54
@dcodeIO dcodeIO merged commit 784521d into AssemblyScript:master Mar 22, 2021
@dcodeIO
Copy link
Member

dcodeIO commented Mar 22, 2021

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants