Skip to content

fix: read stream signature #1742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcodeIO merged 4 commits into from
Mar 22, 2021
Merged

fix: read stream signature #1742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a5fe20c
fix: read stream signature
Mar 17, 2021
52d66cb
fix: remove bounds check
Mar 17, 2021
51ca1b6
fix: revert API and cast in comparison
Mar 18, 2021
f33f1c7
chore: update wat files and add std-wasi to CI features test
Mar 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ jobs:
env:
ASC_FEATURES: mutable-globals,threads,reference-types,bigint-integration,gc
run: |
npm run test:compiler rt/flags features/js-bigint-integration features/reference-types features/threads
npm run test:compiler rt/flags features/js-bigint-integration features/reference-types features/threads std-wasi/process std-wasi/crypto
test-runtimes:
name: "Runtimes"
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion std/assembly/process.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ abstract class WritableStream extends Stream {
abstract class ReadableStream extends Stream {
read(buffer: ArrayBuffer, offset: isize = 0): i32 {
var end = <usize>buffer.byteLength;
if (offset < 0 || offset > end) {
if (offset < 0 || <usize>offset > end) {
throw new Error(E_INDEXOUTOFRANGE);
}
store<usize>(iobuf, changetype<usize>(buffer) + offset);
Expand Down
Loading