Misc Nix Related Modernizations & Improvements#55
Open
doronbehar wants to merge 8 commits into
Open
Conversation
It bothers the nix file, and there is a default value for it on other platforms.
These produce a few warnings during build, but are harmless and not worth the maintenance burden.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I read the
package.nixexpression in Nixpkgs, and I noticed a few wrong things in it (cc @fndov). The (wrong) usage ofclangfelt like something required by upstream, which led me here.The PR includes many changes, most of which don't have to come together, or in this order. Please review the commits one by one. I expect you to object at least some of the changes and everything is open for discussion of course :).