Skip to content

pulse-visualizer: 1.2.2 -> 1.3.9#519573

Merged
Mindavi merged 1 commit into
NixOS:masterfrom
doronbehar:pkg/pulse-visualizer
May 16, 2026
Merged

pulse-visualizer: 1.2.2 -> 1.3.9#519573
Mindavi merged 1 commit into
NixOS:masterfrom
doronbehar:pkg/pulse-visualizer

Conversation

@doronbehar
Copy link
Copy Markdown
Contributor

@doronbehar doronbehar commented May 12, 2026

Things done

In principal there's lot's of room for improvement to the expression, but it'll make sense to do it after upstream PR is accepted:

I should also note, that I experience Audio-Solutions/pulse-visualizer#30 even with this version...

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@doronbehar doronbehar requested a review from fndov May 12, 2026 22:55
@nixpkgs-ci nixpkgs-ci Bot added 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 12, 2026
Copy link
Copy Markdown
Member

@fndov fndov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 15, 2026
@Mindavi
Copy link
Copy Markdown
Contributor

Mindavi commented May 16, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 519573
Commit: e6d314a3b33211ac3f39aef34da5cf954e2e8412


x86_64-linux

✅ 1 package built:
  • pulse-visualizer

Tried running it and seems to run fine for me.

@Mindavi Mindavi added this pull request to the merge queue May 16, 2026
Merged via the queue into NixOS:master with commit aa94d3e May 16, 2026
39 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants