Skip to content

Conversation

@szerintedmi
Copy link
Member

Netlify deploys started to fail on compiler warnings.
The following warnings are resolved to make deploy time compile pass:

Treating warnings as errors because process.env.CI = true.
Most CI servers set it automatically.

Failed to compile.

./src/containers/loan/components/LoanListDetails.js
  Line 2:  'NavLink' is defined but never used  no-unused-vars
./src/containers/underthehood/components/LoanManagerInfo.js
  Line 4:  'Tokens' is defined but never used  no-unused-vars
./src/containers/underthehood/LoansInfoGroup.js
  Line 5:  'stringify' is defined but never used  no-unused-vars
./src/modules/loanManagerProvider.js
  Line 8:  'fetchAllLoans' is defined but never used  no-unused-vars
./src/components/augmint-ui/icon/index.js
  Line 90:  Expected a 'break' statement before 'default'  no-fallthrough

@szerintedmi
Copy link
Member Author

szerintedmi commented Sep 8, 2020

Deploy preview for augmint ready!

Built with commit 6a5d752

https://deploy-preview-734--augmint.netlify.app

@szerintedmi szerintedmi merged commit d67fa8a into staging Sep 8, 2020
@szerintedmi szerintedmi deleted the resolve_compiler_warnings branch September 8, 2020 12:40
@szerintedmi szerintedmi mentioned this pull request Sep 8, 2020
szerintedmi added a commit that referenced this pull request Sep 8, 2020
* upgrade augmint-js to 0.3.6 (#714)

* fix compiler warnings (#734)

* Fixes (#725)

* always show add extra collateral, fix collateral amount decimal point

* addcollateral fixes

* revert

* fix types

Co-authored-by: Viktor Szathmáry <phraktle@gmail.com>

* increase gas limit offered for repay (#733)

increased default gas limit to 250k because 150k gas limit is not enough recently, [repay tx fails](https://etherscan.io/tx/0x6f82dbaef1ab74c515b0205debfa1c2b04c96d4bc911c59f0590b538db0b4f63) 

[tx succeeds](https://etherscan.io/tx/0xa955dd7e2f3948af191ed8912d9a2090fe3ef2971c445b7fddcec4050089a3d7) when gas limit increased but sitll  using only 130k gas.
¯\_(ツ)_/¯

Co-authored-by: Treer Zoltán <38250343+treerz@users.noreply.github.com>
Co-authored-by: Brigitta Forrai <forraibrigi@gmail.com>
Co-authored-by: Viktor Szathmáry <phraktle@gmail.com>
szerintedmi added a commit that referenced this pull request Feb 3, 2021
* upgrade augmint-js to 0.3.6 (#714)

* fix compiler warnings (#734)

* Fixes (#725)

* always show add extra collateral, fix collateral amount decimal point

* addcollateral fixes

* revert

* fix types

Co-authored-by: Viktor Szathmáry <phraktle@gmail.com>

* increase gas limit offered for repay (#733)

increased default gas limit to 250k because 150k gas limit is not enough recently, [repay tx fails](https://etherscan.io/tx/0x6f82dbaef1ab74c515b0205debfa1c2b04c96d4bc911c59f0590b538db0b4f63) 

[tx succeeds](https://etherscan.io/tx/0xa955dd7e2f3948af191ed8912d9a2090fe3ef2971c445b7fddcec4050089a3d7) when gas limit increased but sitll  using only 130k gas.
¯\_(ツ)_/¯

* Bump http-proxy from 1.17.0 to 1.18.1 (#732)

Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.17.0 to 1.18.1.
- [Release notes](https://github.com/http-party/node-http-proxy/releases)
- [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md)
- [Commits](http-party/node-http-proxy@1.17.0...1.18.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Peter Petrovics <peter@augmint.org>

* Bump acorn from 5.7.3 to 5.7.4 (#727)

Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4.
- [Release notes](https://github.com/acornjs/acorn/releases)
- [Commits](acornjs/acorn@5.7.3...5.7.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* yarn version to 1.22.4 (#737)

* yarn version and lock file update
* remove yarn version from dev docs

* fix: upgrade react-tooltip from 3.10.0 to 3.11.6 (#742)

Snyk has created this PR to upgrade react-tooltip from 3.10.0 to 3.11.6.

See this package in npm:


See this project in Snyk:
https://app.snyk.io/org/szerintedmi/project/e9149520-e093-4f5d-8633-58c1b1036435?utm_source=github&utm_medium=upgrade-pr

* fix: upgrade multiple dependencies with Snyk (#741)

Snyk has created this PR to upgrade:
  - react from 16.8.6 to 16.13.1.
    See this package in npm: 
  - react-dom from 16.8.6 to 16.13.1.
    See this package in npm: 

See this project in Snyk:
https://app.snyk.io/org/szerintedmi/project/e9149520-e093-4f5d-8633-58c1b1036435?utm_source=github&utm_medium=upgrade-pr

Co-authored-by: Peter Petrovics <peter@augmint.org>

* fix: upgrade redux-form from 8.2.3 to 8.3.6 (#739)

Snyk has created this PR to upgrade redux-form from 8.2.3 to 8.3.6.

See this package in npm:


See this project in Snyk:
https://app.snyk.io/org/szerintedmi/project/e9149520-e093-4f5d-8633-58c1b1036435?utm_source=github&utm_medium=upgrade-pr

Co-authored-by: Peter Petrovics <peter@augmint.org>

* upgrade ics from 2.15.1 to 2.23.0 (#740)

Snyk has created this PR to upgrade ics from 2.15.1 to 2.23.0.

See this package in npm:


See this project in Snyk:
https://app.snyk.io/org/szerintedmi/project/e9149520-e093-4f5d-8633-58c1b1036435?utm_source=github&utm_medium=upgrade-pr

Co-authored-by: Peter Petrovics <peter@augmint.org>

* Fix watch asset (#744)

* fix asset btn

* upgrade web3 to 1.3.3

* web3 version

* yarn.lock

* try to fix tests

* minor refact

Co-authored-by: Peter Petrovics <peter@augmint.org>
Co-authored-by: Brigitta Forrai <forraibrigi@gmail.com>
Co-authored-by: Viktor Szathmáry <phraktle@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Snyk bot <github+bot@snyk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants