Fix watch asset #744
Merged
Fix watch asset #744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Deploy preview for augmint ready! Built with commit be6eb5c |
gyurka00
reviewed
Jan 27, 2021
Contributor
gyurka00
left a comment
gyurka00
left a comment
There was a problem hiding this comment.
Why do you remove the yarn lock?
Contributor
Author
|
ahh.. coincidence |
gyurka00
previously approved these changes
Jan 27, 2021
szerintedmi
previously approved these changes
Jan 27, 2021
brigittaforrai
dismissed stale reviews from szerintedmi and gyurka00
via
1e962d9
gyurka00
reviewed
Jan 29, 2021
src/components/watchAssetButton.js
Outdated
|
|
||
| this.isMetamask = window.ethereum.isMetamask; | ||
| const eth = window.ethereum; | ||
| this.isMetamask = eth ? eth.isMetamask : null; |
Contributor
There was a problem hiding this comment.
I think you can use window.ethereum?.isMetamask || null
Contributor
There was a problem hiding this comment.
this.isMetamask = window.ethereum?.isMetamask || null;
treerz
previously approved these changes
Jan 29, 2021
Contributor
treerz
left a comment
treerz
left a comment
There was a problem hiding this comment.
just deploy it
the whole website is broken without this fix, it cannot get worse than that
gyurka00
approved these changes
Feb 1, 2021
gyurka00
approved these changes
Feb 1, 2021
treerz
approved these changes
Feb 1, 2021
Merged
szerintedmi
added a commit
that referenced
this pull request
Feb 3, 2021
* upgrade augmint-js to 0.3.6 (#714) * fix compiler warnings (#734) * Fixes (#725) * always show add extra collateral, fix collateral amount decimal point * addcollateral fixes * revert * fix types Co-authored-by: Viktor Szathmáry <phraktle@gmail.com> * increase gas limit offered for repay (#733) increased default gas limit to 250k because 150k gas limit is not enough recently, [repay tx fails](https://etherscan.io/tx/0x6f82dbaef1ab74c515b0205debfa1c2b04c96d4bc911c59f0590b538db0b4f63) [tx succeeds](https://etherscan.io/tx/0xa955dd7e2f3948af191ed8912d9a2090fe3ef2971c445b7fddcec4050089a3d7) when gas limit increased but sitll using only 130k gas. ¯\_(ツ)_/¯ * Bump http-proxy from 1.17.0 to 1.18.1 (#732) Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.17.0 to 1.18.1. - [Release notes](https://github.com/http-party/node-http-proxy/releases) - [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md) - [Commits](http-party/node-http-proxy@1.17.0...1.18.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Petrovics <peter@augmint.org> * Bump acorn from 5.7.3 to 5.7.4 (#727) Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.7.3...5.7.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * yarn version to 1.22.4 (#737) * yarn version and lock file update * remove yarn version from dev docs * fix: upgrade react-tooltip from 3.10.0 to 3.11.6 (#742) Snyk has created this PR to upgrade react-tooltip from 3.10.0 to 3.11.6. See this package in npm: See this project in Snyk: https://app.snyk.io/org/szerintedmi/project/e9149520-e093-4f5d-8633-58c1b1036435?utm_source=github&utm_medium=upgrade-pr * fix: upgrade multiple dependencies with Snyk (#741) Snyk has created this PR to upgrade: - react from 16.8.6 to 16.13.1. See this package in npm: - react-dom from 16.8.6 to 16.13.1. See this package in npm: See this project in Snyk: https://app.snyk.io/org/szerintedmi/project/e9149520-e093-4f5d-8633-58c1b1036435?utm_source=github&utm_medium=upgrade-pr Co-authored-by: Peter Petrovics <peter@augmint.org> * fix: upgrade redux-form from 8.2.3 to 8.3.6 (#739) Snyk has created this PR to upgrade redux-form from 8.2.3 to 8.3.6. See this package in npm: See this project in Snyk: https://app.snyk.io/org/szerintedmi/project/e9149520-e093-4f5d-8633-58c1b1036435?utm_source=github&utm_medium=upgrade-pr Co-authored-by: Peter Petrovics <peter@augmint.org> * upgrade ics from 2.15.1 to 2.23.0 (#740) Snyk has created this PR to upgrade ics from 2.15.1 to 2.23.0. See this package in npm: See this project in Snyk: https://app.snyk.io/org/szerintedmi/project/e9149520-e093-4f5d-8633-58c1b1036435?utm_source=github&utm_medium=upgrade-pr Co-authored-by: Peter Petrovics <peter@augmint.org> * Fix watch asset (#744) * fix asset btn * upgrade web3 to 1.3.3 * web3 version * yarn.lock * try to fix tests * minor refact Co-authored-by: Peter Petrovics <peter@augmint.org> Co-authored-by: Brigitta Forrai <forraibrigi@gmail.com> Co-authored-by: Viktor Szathmáry <phraktle@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Snyk bot <github+bot@snyk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.