Update Sentry (adding in manual event sending)#159
Closed
Conversation
jkmassel
force-pushed
the
update/sentry
branch
7 times, most recently
from
ac4fd7f to
8bf1e66
Compare
jkmassel
force-pushed
the
update/sentry
branch
from
b1dbb16 to
2b6da87
Compare
mokagio
reviewed
Jan 12, 2021
jkmassel
force-pushed
the
update/sentry
branch
from
ae16352 to
1ebf7b6
Compare
jkmassel
force-pushed
the
update/sentry
branch
2 times, most recently
from
323ae49 to
c3e650e
Compare
|
Thanks for taking care of this @jkmassel . Please let me know if you want me to test with Matticspace or WooCommerce |
Use Sentry 6 in the Podspec Fix Sentry version in Podspec Use Sentry 6
Fix project file
Use the Sentry API directly
Fix macOS combine
jkmassel
force-pushed
the
update/sentry
branch
from
68eac14 to
75bc6ca
Compare
mokagio
reviewed
Jan 14, 2021
| init(dsn: String) { | ||
| self.dsn = dsn | ||
| self.jsonEncoder = JSONEncoder() | ||
| self.jsonEncoder.dateEncodingStrategy = .iso8601 |
Contributor
There was a problem hiding this comment.
The pod validation (pod lib lint --allow-warnings) fails because of strategy case is only available from macOS 10.12.
The project and Podfile use 10.12 as the minimum deployment target, but the .podspec is declaring 10.11, so pod lib lint builds with that one.
We need to bump to 10.12 there, too.
Contributor
Author
There was a problem hiding this comment.
Ah nice – thanks for pointing this out!!
Contributor
Author
|
Closing in favour of #166 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.