Merged
Conversation
leandroalonso
approved these changes
Jan 13, 2021
Member
leandroalonso
left a comment
leandroalonso
left a comment
There was a problem hiding this comment.
@jkmassel I guess we can remove the last exclude path from this line: https://github.com/Automattic/Automattic-Tracks-iOS/blob/develop/Automattic-Tracks-iOS.podspec#L15
Then we're good to go! Thanks for this improvement. :)
Contributor
Author
Yeah, good call thanks!! |
jkmassel
force-pushed
the
add/macos-support-for-explat
branch
from
66f7cbd to
3a18378
Compare
Contributor
Author
|
So after trying that, there's a problem with updating to macOS 10.12 (because it starts building for arm64 at that point, which isn't supported by Sentry). We'll need to land #159 first, then remove that chunk of the To avoid conflicts, I'll merge this for now and fix up the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #159 I noticed that the
ABTestingcode wasn't targeting macOS. Because we want to keep this library in sync across both platforms, this PR just runs around and adds everything to the macOS target as well – it was pretty much all already compatible! 😅To Test: