Merged
Conversation
As GH was so kind as to point me to the "contributing guidelines which have been changed since you last contributed" I quickly scanned through the file and most notably, came across a link to the WPCS wiki page, while this link should have gone to the VIPCS wiki. As I was editing the file now anyway, I've made some other changes along the way. * Ask people to search the issue list before opening an issue. * Made a little table to make it easier for people to report upstream issues to the correct repository. * Updated the "custom properties" link to point to the VIPCS wiki. * Updated the PHPUnit installation link. * Updated the `phpunit.xml` example to be in line with the current `phpunit.xml.dist` file. * Updated the expected unit test output.
GaryJones
approved these changes
Jul 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As GH was so kind as to point me to the "contributing guidelines which have been changed since you last contributed" I quickly scanned through the file and most notably, came across a link to the WPCS wiki page, while this link should have gone to the VIPCS wiki.
As I was editing the file now anyway, I've made some other changes along the way.
phpunit.xmlexample to be in line with the currentphpunit.xml.distfile.Includes moving the file to the
.githubsubdirectory.