Hooks/PreGetPosts: add support for hook-ins using short arrays#564
Merged
Hooks/PreGetPosts: add support for hook-ins using short arrays#564
Conversation
GaryJones
previously approved these changes
Jul 29, 2020
Contributor
|
This one now has a merge conflict. |
jrfnl
force-pushed
the
fix/358-pregetpost-support-short-arrays
branch
from
b159efc to
6b6cf10
Compare
Collaborator
Author
|
Yup, I expected that one. Rebased & force pushed. |
As VIPCS is currently using WPCS 2.x, we can use the WPCS `Sniff::find_array_open_close()` method to get the opener/closer for an array independently of the type of array (long/short). Once VIPCS implements PHPCSUtils, this method call should be swopped out for the PHPCSUtils `Arrays::getOpenClose()` method. Addresses #358 for the `PreGetPosts` sniff. Includes unit tests.
GaryJones
approved these changes
Jul 29, 2020
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As VIPCS is currently using WPCS 2.x, we can use the WPCS
Sniff::find_array_open_close()method to get the opener/closer for an array independently of the type of array (long/short).Once VIPCS implements PHPCSUtils, this method call should be swopped out for the PHPCSUtils
Arrays::getOpenClose()method.Addresses #358 for the
PreGetPostssniff.Includes unit tests.