Skip to content

CI: fix build failures #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rebeccahum merged 2 commits into from
Mar 2, 2021
Merged

CI: fix build failures #629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1c62f1
CI: fix build failures [1]
jrfnl Mar 2, 2021
87ddd1b
CI: fix build failures [2]
jrfnl Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions WordPress-VIP-Go/ruleset-test.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ function foo_bar_bar() {

// VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable
function foo_bar_foo() {
$a = 'Hello'; // Warning
$a = 'Hello'; // OK. Unused variables warning silenced.
}

// WordPressVIPMinimum.UserExperience.AdminBarRemoval
Expand Down Expand Up @@ -417,7 +417,7 @@ the_sub_field( 'field' ); // Warning.
the_field( 'field' ); // Warning.
wp_remote_get( $url ); // Warning.
get_posts(); // Warning.
function test_function( $a, $b ) {
function test_function( $a, $b ) { // OK. Unused variables warning silenced.
return create_function( '$a, $b', 'return ( $b / $a ); '); // Warning.
}
wpcom_vip_get_term_link(); // Warning.
Expand Down
2 changes: 0 additions & 2 deletions WordPress-VIP-Go/ruleset-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@
207 => 1,
208 => 1,
212 => 1,
217 => 1,
221 => 1,
223 => 1,
225 => 1,
Expand Down Expand Up @@ -222,7 +221,6 @@
417 => 1,
418 => 1,
419 => 1,
420 => 2,
421 => 1,
423 => 1,
424 => 1,
Expand Down
2 changes: 1 addition & 1 deletion WordPressVIPMinimum/ruleset-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@
393 => 1,
394 => 1,
395 => 1,
402 => 1,
415 => 1,
425 => 1,
451 => 1,
Expand Down Expand Up @@ -269,7 +270,6 @@
399 => 1,
400 => 1,
401 => 1,
402 => 1,
403 => 1,
404 => 1,
405 => 1,
Expand Down