Conversation
PR 618 updated the message type for the `WordPressVIPMinimum.Functions.RestrictedFunctions.cookies_setcookie` error code from `warning` to `error`. However, the ruleset test for the `WordPressVIPMinimum` ruleset was not updated to match. Fixed now.
PR 620 silenced the `VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable` error code in the VIP Go ruleset. However, the ruleset test for the `WordPress-VIP-Go` ruleset was not updated to match. Fixed now.
rebeccahum
approved these changes
Mar 2, 2021
Contributor
rebeccahum
left a comment
rebeccahum
left a comment
There was a problem hiding this comment.
Good sleuthing, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this only fixes the failures in the ruleset tests. There is still another failure under investigation.
CI: fix build failures [1]
PR #618 updated the message type for the
WordPressVIPMinimum.Functions.RestrictedFunctions.cookies_setcookieerror code fromwarningtoerror.However, the ruleset test for the
WordPressVIPMinimumruleset was not updated to match.Fixed now.
CI: fix build failures [2]
PR #620 silenced the
VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariableerror code in the VIP Go ruleset.However, the ruleset test for the
WordPress-VIP-Goruleset was not updated to match.Fixed now.