Remove Batcache references in messaging#618
Merged
rebeccahum merged 2 commits intodevelopfrom Jan 12, 2021
Merged
Conversation
GaryJones
approved these changes
Jan 12, 2021
Contributor
GaryJones
left a comment
There was a problem hiding this comment.
LGTM.
To summarise the changes here, as I see it:
- Original sniffs were written for WPCOM, and so mentioned Batcache.
- The error messages were overridden in WordPress-VIP-Go ruleset to make them more generic (since Batcache isn't used there).
- Since we no longer have any WPCOM, then the original sniff messages can be updated to be more generalised, and the ruleset overrides can be removed.
Merged
Collaborator
|
Reviewed after the fact. Notes:
I will send in a PR shortly to fix the comments in the ruleset test case files for both changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VIP Go does not utilize Batcache and we overwrite the messaging in the ruleset anyways, so I think we can clean it up a bit and remove the Batcache references.
#613 is related as well.