Conversation
Better align with suggested script names at https://github.com/php-pds/composer-script-names
GaryJones
force-pushed
the
fix/composer-script-names
branch
from
0c63b7e to
9e597b3
Compare
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
While I'm not adverse to these changes, it's unclear to me why the https://github.com/php-pds/composer-script-names repo is cited as an authoritative document. Based on the commit history, lack of discussion in issues or PRs, the "rules" stated in that repo sound like one-man's opinion.
The research suggests that it was done with analysis on 36,000+ packages, so while not authoritative in the form of it being from Composer or PHP-FIG, it indicates to me that the names proposed in this PR are better aligned with many other Composer script names in PHP packages in the community. |
These appear when calling `composer list`.
This is no longer needed; the list of installed code standards for PHPCS is reliably updated on `composer install` and `composer update`.
Has the advantages of: - working on Windows machines. - extra CLI args such as `--sniffs` can be passed when calling `composer cs`.
GaryJones
force-pushed
the
fix/composer-script-names
branch
from
9e597b3 to
6d52e98
Compare
|
@GaryJones I'll have a read through the research, don't have time for it right at this moment. |
3 participants
Better align with suggested script names at https://github.com/php-pds/composer-script-names, add script descriptions, and remove a redundant script for manually updating the list of installed code standards into PHPCS.