Conversation
Add support for PHP 8.1 features, including fixing a retokenization of reserved keywords bug in PHPCS 3.7.0.
Brings them more into line with the Composer scripts in WPCS.
VIPCS needs to be compatible with WordPress Coding Standards 3.0.0, which is currently in development on its `develop` branch. WPCS now uses some extra dependencies, which are also in development, so we need to allow for a minimum-stability of dev. Run `composer update -W` to pull those extra dependencies in.
Uses the composer-normalize plugin to keep a consistent order.
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
Hi @GaryJones Thanks for setting this up. The PR is mixing a few changes with different decision points in one PR (Composer normalization and scripts changes vs changing versions of dependencies), but that's no biggie.
I've left a number of comments inline for your perusal.
Other than that, I'd like to suggest not changing the WPCS version to develop as that's a moving target.
I'm still hoping we reach the point where we can tag a 3.0.0-RC release before I leave for my break. Once that's tagged, the WPCS version for this repo could then be set to 3.0.0 (with minimum-stability set to RC), which makes it less of a moving target + makes it more descriptive what's going on.
|
Note: if the change to WPCS |
Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
|
The changes here are mostly now handled in I've skipped the normalizing of the |
2 participants
We need VIPCS to be compatible with WPCS 3.0, so this is the first of a few PRs to address the known compatibility issues.
Composer: up the minimum PHPCS version to 3.7.1
PHPCS 3.7.1 adds support for PHP 8.1 features, including fixing a retokenization of reserved keywords bug in PHPCS 3.7.0. Amends a couple of GitHub workflows for this change too.
Composer: rename scripts
Brings them more in line with the Composer scripts in WPCS.
Composer: add script descriptions
Displayed for
composer list.Composer: use develop branch of WPCS
VIPCS must be compatible with WordPress Coding Standards 3.0.0, currently in development on its
developbranch. WPCS now uses some extra dependencies, which are also in development, so we need to allow for aminimum-stabilityofdev. Runcomposer update -Wto pull those extra dependencies in.Composer: Normalize the order
Uses the composer-normalize plugin to keep a consistent order.
Note: GitHub Actions may report failures whilst this and the next few PRs go through, but I don't want to bundle all the changes into big PRs.