Composer: up the minimum PHPCS version to 3.7.1#742
Merged
Conversation
Add support for PHP 8.1 features, including fixing a retokenization of reserved keywords bug in PHPCS 3.7.0. With a new minimum version of PHPCS, this allows consolidation and simplification of the testing matrix in the `test.yml` workflow.
This was referenced Jan 24, 2023
rebeccahum
approved these changes
Jan 26, 2023
Contributor
Author
|
@rebeccahum Any preference on whether this could go into a 2.3.4, or hold on to a 3.0? |
jrfnl
reviewed
Jan 26, 2023
Collaborator
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
Just left some questions, no biggie.
Collaborator
|
As for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for PHP 8.1 features, including fixing a retokenization of reserved keywords bug in PHPCS 3.7.0.
With a new minimum version of PHPCS, this allows consolidation and simplification of the testing matrix in the
test.ymlworkflow.I'd like to get this into 2.3.4, but this may be semantically better for 3.0.0?