Displaying updated time instead of creation time in Notepad Dashboard Widget#468
Merged
rinatkhaziev merged 2 commits intoAutomattic:masterfrom Jun 15, 2018
TheCrowned:fix/465-notepad-updated-time
Merged
Displaying updated time instead of creation time in Notepad Dashboard Widget#468rinatkhaziev merged 2 commits intoAutomattic:masterfrom TheCrowned:fix/465-notepad-updated-time
rinatkhaziev merged 2 commits intoAutomattic:masterfrom
TheCrowned:fix/465-notepad-updated-time
Conversation
sboisvert
previously requested changes
May 28, 2018
Contributor
sboisvert
left a comment
sboisvert
left a comment
There was a problem hiding this comment.
While the whitespace changes are good, they should be part of a separate PR. You can read more about the reasoning here: Automattic/sensei#2157 and https://vip.wordpress.com/documentation/creating-good-changesets/
The feedback on PRs in #464 also applies :)
Contributor
Author
|
I have updated the description with some more details and pushed an additional commit removing the whitespace changes :) |
mdbitz
approved these changes
May 29, 2018
mdbitz
left a comment
mdbitz
left a comment
There was a problem hiding this comment.
@rinatkhaziev I've tested these changes and confirmed the behavior. Do you mind taking a look and merging as appropriate.
Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Notepad Dashboard Widget was showing the note creation time, even if the label said last updated at, as reported in #465. The issue was due to the usage of
get_the_time()instead ofget_the_modified_time().