Replace “$” with “jQuery”.#499
Merged
rebeccahum merged 1 commit intoAutomattic:masterfrom Sep 11, 2019
Merged
Conversation
Contributor
Author
|
If it matters, in my case (and at least one other user’s case), it specifically was preventing the Co-Authors Plus plugin from writing the author selection UI to the Authors metabox. See this forum post for details: https://wordpress.org/support/topic/cant-select-change-author-in-add-new-post/#post-11133237 |
ghost
mentioned this pull request
Contributor
Author
|
It would be great if someone would merge this PR. It’s been sitting here for 4 months, and it fixes an issue that’s breaking functionality in other plugins. |
Contributor
Author
|
Please, somebody look at this PR and merge it. |
Contributor
Author
|
Is anybody even maintaining this plugin anymore? |
|
@rebeccahum Could you Merge this one please? @mikeyarce |
rebeccahum
approved these changes
Sep 11, 2019
Contributor
Author
|
THANK YOU! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was getting a missing function error for the$, and it was creating a conflict with another plugin. As I understand it, when using jQuery in WordPress, best practice is to always use the jQuery function instead of the $ . Updated this file (the source of the error) and everything is peachy. It would be great to have this change rolled into the plug-in, so that I don’t have to keep making it after each update.
Also, I hope I’m going about this the correct way. I got followed the instructions from the plugin website (I think). I’ve never use git for collaboration, so if I did this wrong, please feel free to correct me, it won’t hurt my feelings at all.