editorial-comments.js - replace faulty $() with jQuery() to match the rest of file#506
Closed
jerclarke wants to merge 2 commits intoAutomattic:masterfrom
Closed
editorial-comments.js - replace faulty $() with jQuery() to match the rest of file#506jerclarke wants to merge 2 commits intoAutomattic:masterfrom
$() with jQuery() to match the rest of file#506jerclarke wants to merge 2 commits intoAutomattic:masterfrom
Conversation
… the rest of file - On one of my sites, I was getting a site-breaking js error for `$ not defined` caused by line 26 of this file, which had a `$()` jQuery command - For some reason, most of my sites never had this problem, but this one did. Maybe it's a combination of plugins and a common one makes `$()` available by coincidence. - Either way, the surrounding code makes it obvious that `editorial-comments` relies on `jQuery()` being available, rather than `$()` - This patch just fixes that one line (which was the most recently added, it's part of the "notified list" feature added in 0.9) to match the rest and use `jQuery()` like a good kid.
|
@jerclarke #499 is already there. |
|
#499 was merged! |
Contributor
|
Closing as #499 addressed this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$ not definedcaused by line 26 of this file, which had a$()jQuery command$()available by coincidence.editorial-commentsrelies onjQuery()being available, rather than$()jQuery()like a good kid.