Fixes non-variable being passed by reference#667
Merged
Conversation
Contributor
Author
|
Looking at the test failures, it looks like the problem is: The problem happens because the whole file is indented incorrectly, but I don't think we should worry about that for this specific PR. |
Member
|
Tested and confirmed everything is OK. |
htdat
approved these changes
Jun 14, 2021
Member
htdat
left a comment
htdat
left a comment
There was a problem hiding this comment.
🚢!
(I noticed that I did not formally send this review so... I am doing that now).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #656
Currently there's a PHP Notice happening when you save screen option changes:
[07-Jun-2021 18:36:16 UTC] PHP Notice: Only variables should be passed by reference in wp-content/plugins/Edit-Flow/common/php/screen-options.php on line 169Steps to Test
wp-admin/index.php?page=story-budget