Closed
Conversation
Member
Author
|
Looks like all PHP tests failed for the same reason as mentioned here #667 (comment) I think eventually we may run |
Contributor
|
Opened #733 to do this, so closing this off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #661
Description
The reason for this PR is mentioned in #661.
What I've done to do this cleanup:
jquery.quicksearch.jsand removed the relevant places.jquery-quicksearchand removed the relevant things.quicksearchand removed the relevant things. After this PR, there are still few places for this keywordquicksearchin modules/notifications/lib/notifications.css and modules/user-groups/lib/user-groups.css but I think we should keep it.Steps to Test
Notesection in this PR Fix jQuery warnings as WordPress upgraded it from 1.12.4-wp to 3.5.1 #649