Merged
Conversation
1286528 to
a50a6b2
Compare
a50a6b2 to
e55af52
Compare
Collaborator
Author
|
To summarize what I've done: I've introduced a structure ( I then added UI for |
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Feb 6, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v0.18.1` -> `v0.19.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>Automattic/harper (Automattic/harper/harper-ls)</summary> ### [`v0.19.1`](https://github.com/Automattic/harper/releases/tag/v0.19.1) [Compare Source](Automattic/harper@v0.18.1...v0.19.1) #### What's Changed The biggest change in this version: the ability to ignore lints. This is some pretty new code, so we hope to hear from you all to see how we can improve it. - feat: issue templates by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#539 - feat(core): even more holidays by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#533 - feat(core): implement "despite of" lint by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#531 - feat(html): condense spaces like most HTML parsers by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#546 - Ignore Lints by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#529 - fix(core): [#​548](Automattic/harper#548) `you` is not a verb by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#551 - docs: mention [#​536](Automattic/harper#536) on installation pages by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#538 - Site fixes and updates by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#552 - feat(core): created framework for correcting common phrases by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#550 - feat(core): condense multi-token Latin words and phrases by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#473 **Full Changelog**: Automattic/harper@v0.18.1...v0.19.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNjEuNiIsInVwZGF0ZWRJblZlciI6IjM5LjE2MS42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In conversations I've had about Harper (including in #364), a common request has been the ability to ignore individual lint results. I've avoided tackling this problem until now, since I was concerned it would disincentivize us from fixing false-positives in our rules. Now that we're rolling out more integrations, the context has shifted enough that this is now an important feature.
The Plan
I plan on making significant changes to the
harper-core::lintingmodule to make this happen.The implementation should have a general-enough API that it can be consumed in
harper-ls(as a code action), and consumers ofharper.js.We will store each lint to be ignored in a persistent manner, that is compatible with whatever client is consuming Harper.
This PR will remain a draft until completion.