Skip to content

docs: mention #536 on installation pages#538

Merged
elijah-potter merged 2 commits intomasterfrom
mention-536
Jan 31, 2025
Merged

docs: mention #536 on installation pages#538
elijah-potter merged 2 commits intomasterfrom
mention-536

Conversation

@elijah-potter
Copy link
Copy Markdown
Collaborator

In #536, it was revealed that you may need an additional dependency on certain platforms. This PR updates the documentation to mention it.

@elijah-potter
Copy link
Copy Markdown
Collaborator Author

@eduardz1 does this look good?

@eduardz1
Copy link
Copy Markdown
Contributor

@eduardz1 does this look good?

Yes! Perhaps I can try investigating if it's reproducible in a VM and if it's really the only package that needs to be installed. I just don't have too much time for it this week, sorry

@elijah-potter
Copy link
Copy Markdown
Collaborator Author

@eduardz1, no worries. We're in no rush. Let me know when you have time to look at it and if there are any other edits I should make.

@elijah-potter elijah-potter added the documentation Improvements or additions to documentation label Jan 29, 2025
@eduardz1
Copy link
Copy Markdown
Contributor

eduardz1 commented Jan 31, 2025

I can't reproduce the bug, in Ubuntu 24.04 the package build-essential already bundles libstdc++-13-dev so I can't really see any reason why it wouldn't pick that up.

I have tried both in a Ubuntu 24.04 and Pop_OS! 24.04 with the Cosmic alpha on a VM, on Ubuntu I can confirm that, other than the rust tool chain, build-essential is required, on Pop_OS! it's already installed out of the box.

I would suggest only recommending installing build-essential

@elijah-potter
Copy link
Copy Markdown
Collaborator Author

@eduardz1, sounds good. Am I free to merge?

@eduardz1
Copy link
Copy Markdown
Contributor

@eduardz1, sounds good. Am I free to merge?

Yes

elijah-potter and others added 2 commits January 31, 2025 10:28
Co-authored-by: eduardz1 <eduardz1@users.noreply.github.com>
Co-authored-by: eduardz1 <eduardz1@users.noreply.github.com>
@elijah-potter elijah-potter merged commit 5abbd6d into master Jan 31, 2025
@elijah-potter elijah-potter deleted the mention-536 branch January 31, 2025 17:28
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Feb 6, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v0.18.1` -> `v0.19.1` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>Automattic/harper (Automattic/harper/harper-ls)</summary>

### [`v0.19.1`](https://github.com/Automattic/harper/releases/tag/v0.19.1)

[Compare Source](Automattic/harper@v0.18.1...v0.19.1)

#### What's Changed

The biggest change in this version: the ability to ignore lints. This is some pretty new code, so we hope to hear from you all to see how we can improve it.

-   feat: issue templates by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#539
-   feat(core): even more holidays by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#533
-   feat(core): implement "despite of" lint by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#531
-   feat(html): condense spaces like most HTML parsers by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#546
-   Ignore Lints by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#529
-   fix(core): [#&#8203;548](Automattic/harper#548) `you` is not a verb by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#551
-   docs: mention [#&#8203;536](Automattic/harper#536) on installation pages by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#538
-   Site fixes and updates by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#552
-   feat(core): created framework for correcting common phrases by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#550
-   feat(core): condense multi-token Latin words and phrases by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#473

**Full Changelog**: Automattic/harper@v0.18.1...v0.19.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNjEuNiIsInVwZGF0ZWRJblZlciI6IjM5LjE2MS42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants