test(core): confirm that #720 is no longer present

[elijah-potter]

Issues

Confirms that we previously fixed #720

Description

Added unit tests from #720 to confirm that it has been truly resolved.

Checklist

• I have performed a self-review of my own code
• I have added tests to cover my changes

[hippietrail]

I still get #720 for the cases I posted in a comment on Feb 22: Yes so then sorry you didn't receive the memo about the meeting changes.
Yes so then sorry you had to wait so long for a response from our team.
Yes so then sorry you felt left out during the discussion; we value your input.
Yes so then sorry you missed the deadline; we can discuss an extension.
Yes so then sorry you encountered issues with the software; let me help you troubleshoot.

[elijah-potter]

Hmmm... That's strange. The unit tests are coming up fine for your examples. They are also clean when I open a buffer.

[hippietrail]

Hmmm... That's strange. The unit tests are coming up fine for your examples. They are also clean when I open a buffer.

I had some doubts it was being checked by an out-of-date harper-ls process. But that doesn't seem to be the case. So I tried just lint but apparently that hasn't been updated to pass --dialect to harper-cli lint. So I tried harper-cli lint and it passed with no lints in different dialects. To make sure it was working I edited my test file with a random spello - now it flags all nine lines - and continues to even after removing the spello! same whether I run from target/release or target/debug

Hmm but does this maybe running these is not a fresh build and the fresh build just makes is hidden elsewhere?

But maybe I'm still doing something wrong trying to verify the test branch?

cargo install --git https://github.com/automattic/harper --branch test-720 harper-cli --locked

No I think I've ruled that out. You can see I'm on the right branch:

All tests still passing in cargo test too.

[elijah-potter]

I ran that same command on my system, then ran harper-cli lint with your example text. No lints found.

Maybe re-run git clean -xf .?

[hippietrail]

I ran that same command on my system, then ran harper-cli lint with your example text. No lints found.

Maybe re-run git clean -xf .?

Argh! It was coming from a different rule - in matcher-rs

        // mixing up than/then in context
        triggers.extend(pt! {
            "then","her" => "than her",
            "then","hers" => "than hers",
            "then","him" => "than him",
            "then","his" => "than his",
            "then","last","week" => "than last week"
        });