Skip to content

Should check that obj.toJSON is a function before calling it#4

Closed
ghost wants to merge 2 commits intomasterfrom
unknown repository
Closed

Should check that obj.toJSON is a function before calling it#4
ghost wants to merge 2 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Oct 23, 2015

No description provided.

@rhoggSugarcrm
Copy link

Hey @darrachequesne any idea when this will be merged? This is blocking us from upgrading our version of Karma-runner because of karma-runner/karma#1686

Thanks!

@darrachequesne
Copy link

Hi! I have no idea!

ping @rauchg > hi! are you still able to commit in this repository?

Maybe this PR #2 could be merged too before releasing 0.1.7? ❤️

@darrachequesne
Copy link

(excuse me for the double post) @jderuere could you add a test to prevent any future regression (I edited my comment here but you may not have seen it) ?

@ghost
Copy link
Author

ghost commented Nov 10, 2015

Any possibility to improve the situation?

@darrachequesne
Copy link

@jderuere hi! I don't know if you've been notified, but your PR has been merged here https://github.com/socketio/has-binary

And release with has-binary@0.1.7 🤘

@ghost
Copy link
Author

ghost commented Nov 20, 2015

Yes I saw it! It's great, thank you

2015-11-19 16:55 GMT-05:00 Damien Arrachequesne notifications@github.com:

@jderuere https://github.com/jderuere hi! I don't know if you've been
notified, but your PR has been merged here
https://github.com/socketio/has-binary

And release with has-binary@0.1.7 [image: 🤘]


Reply to this email directly or view it on GitHub
#4 (comment).

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants