Skip to content

Should check that obj.toJSON is a function before calling it #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 2 commits into from
Closed

Should check that obj.toJSON is a function before calling it #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f281e8
Should check that obj.toJSON is a function before calling it
Oct 30, 2015
4b65767
Modify unit test to verify that a JSON object can contains a toJSON a…
Nov 6, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ function hasBinary(data) {
}
}
} else if (obj && 'object' == typeof obj) {
if (obj.toJSON) {
if (obj.toJSON && 'function' == typeof obj.toJSON) {
obj = obj.toJSON();
}

Expand Down
4 changes: 2 additions & 2 deletions test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@ describe('has-binarydata', function(){
});

it('should work with an object that does not contain binary', function() {
var ob = {a: 'a', b: [], c: 1234};
var ob = {a: 'a', b: [], c: 1234, toJSON: '{\"a\": \"a\"}'};
assert(!hasBinary(ob));
});

it('should work with an object that contains a buffer', function() {
var ob = {a: 'a', b: new Buffer('abc'), c: 1234};
var ob = {a: 'a', b: new Buffer('abc'), c: 1234, toJSON: '{\"a\": \"a\"}'};
assert(hasBinary(ob));
});

Expand Down