GitHub Actions: Test on the latest macOS X64 and ARM64#2403
Closed
cclauss wants to merge 1 commit intoAutomattic:masterfrom
Closed
GitHub Actions: Test on the latest macOS X64 and ARM64#2403cclauss wants to merge 1 commit intoAutomattic:masterfrom
cclauss wants to merge 1 commit intoAutomattic:masterfrom
Conversation
Contributor
|
Hi, thanks for asking. It appears that you haven't updated the changelog. |
Contributor
Author
|
Done. |
Contributor
Author
|
@pranav1344 Your review, please. |
|
up, this may solve the issue with the installation on M1 devices |
Contributor
Author
|
This might not solve the issue but it might make it clearer which would help us focus on solutions. @pranav1344 The testing modernizations in https://github.com/Automattic/node-canvas/pulls/cclauss would be useful to put into place. |
Contributor
Author
|
@zbjornson Your review, please. |
1 similar comment
Contributor
Author
|
@zbjornson Your review, please. |
On GitHub Actions macOS-13 is X64 and macOS-14 is ARM64. https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On GitHub Actions macOS-13 is X64 and macOS-14 is ARM64.
https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
Thanks for contributing!