Skip to content

Modernize node version matrix#2465

Merged
chearon merged 1 commit intomasterfrom
ch/node-versions
Dec 23, 2024
Merged

Modernize node version matrix#2465
chearon merged 1 commit intomasterfrom
ch/node-versions

Conversation

@chearon
Copy link
Copy Markdown
Collaborator

@chearon chearon commented Dec 6, 2024

These are the currently supported versions. Luckily the Windows file path issue was backported to node 20.

These are the currently supported versions. Luckily the Windows
file path issue was backported to node 20.
Comment thread .github/workflows/ci.yaml
strategy:
matrix:
node: [18.12.0, 20.9.0]
node: [18.20.5, 20.18.1, 22.12.0, 23.3.0]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!! It would be better to have a
canary in the coal mine to spot future breakage.

Suggested change
node: [18.20.5, 20.18.1, 22.12.0, 23.3.0]
node: [18.20.5, 20.18.1, 22.12.0, latest]

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm only when we push though. I wish I'd pinned more versions in the prebuild scripts because it contributed to random failures.

I think new Node versions are something we have to explicitly do work for rather than something that should start potentially breaking builds. @LinusU any opinions?

Sorry about your other PR, I looked for existing ones but somehow still missed it.

Copy link
Copy Markdown
Contributor

@cclauss cclauss Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My sense with latest is that there is a chance that CI tells us we have a problem before end users complain and that the non-latest jobs assure us that only the bleed-edge end users are seeing those problems.

@cclauss
Copy link
Copy Markdown
Contributor

cclauss commented Dec 16, 2024

Please finalize the testing and create a new release.

On the nodejs/node-gyp repo there are six pages of issues that mention node-canvas and there has not been a new release in two years.

@chearon chearon merged commit b6b2dc7 into master Dec 23, 2024
@chearon chearon deleted the ch/node-versions branch December 23, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants