Skip to content

Ignore Visual C++ 2013 compilation warnings#441

Merged
TooTallNate merged 4 commits intoAutomattic:masterfrom
pandell:ignore-winwarnings
Jun 26, 2014
Merged

Ignore Visual C++ 2013 compilation warnings#441
TooTallNate merged 4 commits intoAutomattic:masterfrom
pandell:ignore-winwarnings

Conversation

@milang
Copy link
Contributor

@milang milang commented Jun 26, 2014

  • Compilation warnings no longer pollute output when installing node-canvas in Windows
  • Fixed double->float conversion warnings in trivial cases
  • Removed unneeded #include <nan.h>

@101100
Copy link

101100 commented Jun 26, 2014

Changes look good and I am able to build successfully on Ubuntu and Windows (with less yellow text). 🍪

TooTallNate added a commit that referenced this pull request Jun 26, 2014
Ignore Visual C++ 2013 compilation warnings
@TooTallNate TooTallNate merged commit 5f6b64b into Automattic:master Jun 26, 2014
@milang milang deleted the ignore-winwarnings branch June 26, 2014 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants