On Windows, copy required DLLs next to ".node" file#442
Merged
TooTallNate merged 1 commit intoAutomattic:masterfrom Jun 26, 2014
Merged
On Windows, copy required DLLs next to ".node" file#442TooTallNate merged 1 commit intoAutomattic:masterfrom
TooTallNate merged 1 commit intoAutomattic:masterfrom
Conversation
Contributor
|
Great idea! |
Contributor
Author
|
Rebased on top of merged #441. |
|
I was able to run several of the examples on my Windows 8.0 machine without adding the GTK DLLs to my path. Without the copied DLLs, the same examples fail. 🍪 |
TooTallNate
added a commit
that referenced
this pull request
Jun 26, 2014
On Windows, copy required DLLs next to ".node" file
Contributor
|
Thanks! |
Contributor
Author
|
@TooTallNate thank you for merging. Any chance you might publish the updates to |
Contributor
|
@milang Doesn't look like I have npm publish rights. @visionmedia @kangax Can one of you |
Collaborator
|
@TooTallNate sure, try now |
Contributor
|
Ok, v1.1.5 published to npm. Cheers! On Thu, Jun 26, 2014 at 3:57 PM, Juriy Zaytsev notifications@github.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pull request on top of #441, but could be rebased and used independently.
It adds a postbuild target that will copy required DLLs from
(GTK_Root)/binto target directory so thatcanvas.nodefile can be loaded and used without requiring(GTK_Root)/binto be inPATH.