[#3083] Configure application wide Clock#4591
Closed
jangalinski wants to merge 2 commits into
Closed
Conversation
- allows to get/set clock on a central util class without directly working with a static field - adjusted all tests - introduced timestamp-less constructor so only GenericEventMessage needs to know about the clock - todo: also register in component registry
Contributor
|
The ticket is targetted at 5.2.0, but this PR is targetted at Axon-5.1.x ? |
Contributor
This should indeed be targeted towards |
smcvb
reviewed
May 20, 2026
Collaborator
Author
|
Closing in favor of #4592 due to wrong target branch. |
smcvb
requested changes
May 20, 2026
Contributor
smcvb
left a comment
smcvb
left a comment
There was a problem hiding this comment.
Two nits, otherwise this looks good to me. With the exception that it's targeted towards axon-5.1.x, while it's a change for main/5.2.0!
Collaborator
Author
|
The nits where addressed in #4592 |
smcvb
added
Type: Feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced ClockUtils to replace
GenericEventMessage.clockas the central keeper of current clock.Hint:
ComponentRegistrywill fix #3083