[#3083] Configure application wide Clock#4592
Open
jangalinski wants to merge 6 commits into
Open
Conversation
jangalinski
added
the
Type: Feature
- allows to get/set clock on a central util class without directly working with a static field - adjusted all tests - introduced timestamp-less constructor so only GenericEventMessage needs to know about the clock - todo: also register in component registry
jangalinski
force-pushed
the
feature/3083/clockutils
branch
from
c73f34f to
ad980de
Compare
smcvb
added
the
Priority 2: Should
smcvb
reviewed
May 20, 2026
smcvb
reviewed
May 20, 2026
smcvb
approved these changes
May 20, 2026
Contributor
smcvb
left a comment
smcvb
left a comment
There was a problem hiding this comment.
My concerns have been addressed, hence I'm approving this pull request.
MateuszNaKodach
approved these changes
May 20, 2026
Contributor
MateuszNaKodach
left a comment
MateuszNaKodach
left a comment
There was a problem hiding this comment.
I think we can merge that and then work on the registry in the following PRs.
jangalinski
requested review from
hjohn,
laura-devriendt-lemon and
zambrovski
and removed request for
a team
- first decied to leave in to not break any public facing parts, but its been removed on GenericEventMessage as well and its better to stay consistent
smcvb
reviewed
May 20, 2026
| int gapTimeout, | ||
| Logger logger | ||
| Logger logger, | ||
| @Deprecated(forRemoval = true, since = "5.2.0") |
Contributor
There was a problem hiding this comment.
Perhaps GitHub is acting up...but the Clock wasn't here before your changes, right?
smcvb
reviewed
May 20, 2026
| return TrackingToken.fromContext(eventEntry).orElse(null); | ||
| } | ||
| return TrackingToken.fromContext(eventEntry).orElse(null); | ||
| } |
Contributor
There was a problem hiding this comment.
Indentation seems off to me here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pr resolves #3083.