Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
203 commits
Select commit Hold shift + click to select a range
30d0ec1
Update to new child-resource structure progress
lsnoddy Nov 16, 2021
7b8ea9f
Merge branch 'main' of https://github.com/lsnoddy/ResourceModules int…
lsnoddy Nov 16, 2021
e725966
Progress check-in
lsnoddy Nov 16, 2021
0454fa2
Added managed cluster name parameter
lsnoddy Nov 17, 2021
aad50a9
Updated readme
lsnoddy Nov 17, 2021
8e3f37e
Merge branch 'Azure:main' into main
lsnoddy Nov 17, 2021
eb9ac8f
Updated readme file
lsnoddy Nov 18, 2021
4895bfd
Updated readme
lsnoddy Nov 18, 2021
a24964d
Push updated Readme file(s)
Nov 18, 2021
9da3646
Updated readme
lsnoddy Nov 18, 2021
3ccc8dd
Merge branch 'main' of https://github.com/lsnoddy/ResourceModules
lsnoddy Nov 18, 2021
4210ecf
Added test param file
lsnoddy Nov 18, 2021
4ce1e3b
Updated subscriptionId
lsnoddy Nov 18, 2021
a9726f6
Added test param file
lsnoddy Nov 18, 2021
ed984d6
Removed subscription id
lsnoddy Nov 18, 2021
0380167
Modified test variables
lsnoddy Nov 18, 2021
ecf407a
Modified test variables
lsnoddy Nov 18, 2021
40ffa48
Test dependency values
lsnoddy Nov 18, 2021
f03ac3a
Updated parameters
lsnoddy Nov 18, 2021
d056b74
Removed local files used for testing
lsnoddy Nov 18, 2021
8f3447b
Merge branch 'Azure:main' into main
lsnoddy Nov 18, 2021
a792c19
Updated readme
lsnoddy Nov 18, 2021
d128feb
Merge branch 'main' of https://github.com/lsnoddy/ResourceModules
lsnoddy Nov 18, 2021
cc8c087
Updated readme
lsnoddy Nov 18, 2021
30a00ca
Revert "Push updated Readme file(s)"
lsnoddy Nov 18, 2021
20a3955
Updated readme
lsnoddy Nov 18, 2021
5139c68
Updated both readme files and agentPool paramter name consistency
lsnoddy Nov 18, 2021
39ae6ce
Push updated Readme file(s)
Nov 18, 2021
20c6a88
Merge branch 'Azure:main' into main
lsnoddy Nov 18, 2021
5621dcb
Updated Api to API to appease linter
lsnoddy Nov 18, 2021
9b70753
Merge branch 'main' of https://github.com/lsnoddy/ResourceModules
lsnoddy Nov 18, 2021
739eaaa
Revert "Push updated Readme file(s)"
lsnoddy Nov 18, 2021
2b7cb79
Reverted inadvertent readme change
lsnoddy Nov 18, 2021
49b9db4
Updated agentPool param description
lsnoddy Nov 18, 2021
c0bd1e1
Push updated Readme file(s)
Nov 18, 2021
a83d800
Revert "Push updated Readme file(s)"
lsnoddy Nov 18, 2021
0bb00a6
Nodepools one word per linter error
lsnoddy Nov 18, 2021
f091548
Merge branch 'Azure:main' into main
lsnoddy Nov 19, 2021
c3eb913
Push updated Readme file(s)
Nov 19, 2021
2f2ca3e
Updated agentPool parameter name
lsnoddy Nov 19, 2021
d8a05dd
Merge branch 'main' of https://github.com/lsnoddy/ResourceModules
lsnoddy Nov 19, 2021
c124011
Updated agentPools parameter name
lsnoddy Nov 19, 2021
c16d00b
Revert "Push updated Readme file(s)"
lsnoddy Nov 19, 2021
c0dbb14
Merge branch 'Azure:main' into main
lsnoddy Nov 30, 2021
74848f7
Push updated Readme file(s)
Nov 30, 2021
0b4967c
Merge branch 'Azure:main' into main
lsnoddy Dec 7, 2021
7ddf8d8
Added parameters for all agentPool properties
lsnoddy Dec 7, 2021
9a08b67
Merge branch 'main' of https://github.com/lsnoddy/ResourceModules int…
lsnoddy Dec 7, 2021
2c7a003
Updated name parameter
lsnoddy Dec 7, 2021
18e8d8f
Added required systemAssignedIdentity param for testing
lsnoddy Dec 7, 2021
7d4842b
Added type parameter
lsnoddy Dec 7, 2021
a3e16d2
Updated containerLogMaxFiles
lsnoddy Dec 7, 2021
fd4f994
Updated containerLogMaxFiles
lsnoddy Dec 7, 2021
1d4d23e
Updated cpuManagerPolicy param
lsnoddy Dec 7, 2021
deef818
Updated image high and image low threshold params
lsnoddy Dec 7, 2021
89a50bd
Updated topologyManagerPolicy param
lsnoddy Dec 7, 2021
663696d
Updated transparentHugePageDefrag and transparentHugePageEnabled
lsnoddy Dec 7, 2021
296902c
Updated osType parameter
lsnoddy Dec 7, 2021
b9ba9db
Updated proximityPlacementGroupID
lsnoddy Dec 7, 2021
e839e3b
Updated proximityPlacementGroupId
lsnoddy Dec 7, 2021
ddb628d
proximityPlacementGroupId test
lsnoddy Dec 7, 2021
7d59468
Updated parameter default values
lsnoddy Dec 7, 2021
a23bf71
Updated nodePublicIpPrefixId param
lsnoddy Dec 8, 2021
ccd9582
Updated nodePublicIpPrefixId
lsnoddy Dec 8, 2021
5fb7155
Updated string values with null when empty
lsnoddy Dec 8, 2021
e3f2611
Ucommented proximiytPlacementGroupId
lsnoddy Dec 8, 2021
ce56a72
Added default vm size
lsnoddy Dec 8, 2021
84ecd5f
Change maxPods default to 10
lsnoddy Dec 8, 2021
09bf068
Changed maxPods default
lsnoddy Dec 8, 2021
a859702
Param default mgmt
lsnoddy Dec 8, 2021
8b58c1c
Update osDiskType default
lsnoddy Dec 8, 2021
42de993
Set osSKU default
lsnoddy Dec 8, 2021
5125f28
Updated parameters
lsnoddy Dec 8, 2021
978782d
Updated sourceResourceId parameter default
lsnoddy Dec 8, 2021
3d1dd7a
Updated sourceResourceId
lsnoddy Dec 8, 2021
fa7045d
Updated creationData variable
lsnoddy Dec 8, 2021
3a9d6db
Comment out creationData - test
lsnoddy Dec 8, 2021
a0c81d9
Updated gpuInstanceProfile
lsnoddy Dec 8, 2021
bee9575
Updated gpu instance profile
lsnoddy Dec 8, 2021
4ae05f0
Updated osDiskType
lsnoddy Dec 8, 2021
98d034c
Updated sourceResourceId
lsnoddy Dec 8, 2021
0891302
Updated sourceResourceId
lsnoddy Dec 8, 2021
de7941c
Updated conatinerLog params
lsnoddy Dec 8, 2021
2f6f31e
Updated containerLogMaxFiles
lsnoddy Dec 8, 2021
603d5f2
Updated swapFileSize param
lsnoddy Dec 8, 2021
0579e73
swap file size update
lsnoddy Dec 8, 2021
9b01703
Updated swapFileSize
lsnoddy Dec 8, 2021
52d01aa
Updated netCoreSomaxconn
lsnoddy Dec 8, 2021
d7ef505
Updated netcoreSomaxconn param
lsnoddy Dec 8, 2021
6c04c8c
Updated netCoreNetdevMaxBacklog param
lsnoddy Dec 8, 2021
c1d836a
Updated netCoreRmemDefault param
lsnoddy Dec 8, 2021
9fef014
Updated netCoreOptmemMax
lsnoddy Dec 9, 2021
d89cb45
Updated netCoreWmemDefault param
lsnoddy Dec 9, 2021
b327cf9
Updated netCoreWmemMax
lsnoddy Dec 9, 2021
5129755
Update netCoreWmemMax param
lsnoddy Dec 9, 2021
5a0deda
Updated netCoreOptmemMax param
lsnoddy Dec 9, 2021
355c95f
Updated netIpv4TcpMaxSynBacklog param
lsnoddy Dec 9, 2021
a49a68e
Updated netIpv4TcpMaxTwBuckets param
lsnoddy Dec 9, 2021
6ad6932
Update netIpv4TcpFinTimeout param
lsnoddy Dec 9, 2021
3adbb7e
Update etIpv4TcpKeepaliveTime param
lsnoddy Dec 9, 2021
81c59d0
Updated netIpv4TcpKeepaliveProbes
lsnoddy Dec 9, 2021
7db9d72
Updated netIpv4TcpkeepaliveIntvl param
lsnoddy Dec 9, 2021
aa9f5b4
Updated netIpv4NeighDefaultGcThresholds params
lsnoddy Dec 9, 2021
c1453a7
Updated netIpv4NeighDefaultGcThresh2
lsnoddy Dec 9, 2021
94dc04d
Updated Sysctl settings
lsnoddy Dec 9, 2021
9bbc954
Removed unneccessary properties object
lsnoddy Dec 9, 2021
9422ef3
Registry name test
lsnoddy Dec 10, 2021
983e0fd
Updated readme files
lsnoddy Dec 12, 2021
f0413be
Updated parameter files for new agentpool format
lsnoddy Dec 13, 2021
b1d50c2
Updated readme files
lsnoddy Dec 13, 2021
25ad3d9
Merge branch 'Azure:main' into main
lsnoddy Dec 13, 2021
55df214
Update platform dependencies
lsnoddy Dec 13, 2021
4a6be5d
Merge branch 'main' of https://github.com/lsnoddy/ResourceModules
lsnoddy Dec 13, 2021
aad14b5
Updates
lsnoddy Dec 13, 2021
e9be3a1
Updated readme
lsnoddy Dec 13, 2021
a801e70
Updated readme
lsnoddy Dec 13, 2021
d73ce94
Updated readme
lsnoddy Dec 13, 2021
08c4fb8
Revert "Update platform dependencies"
lsnoddy Dec 13, 2021
d2b6584
Update
lsnoddy Dec 13, 2021
9ee57d7
Update
lsnoddy Dec 13, 2021
f698b13
Restore file
lsnoddy Dec 13, 2021
c36c67b
Restore file
lsnoddy Dec 13, 2021
73e0b0c
Test restore
lsnoddy Dec 13, 2021
0f5f1ad
Test revert
lsnoddy Dec 13, 2021
6c5005c
Restore file
lsnoddy Dec 13, 2021
40d4228
Updated
lsnoddy Dec 13, 2021
757c7b9
Removed agentPool example
lsnoddy Dec 13, 2021
eb4fefb
Removed extra spaces and changed comparison to not equal
lsnoddy Dec 13, 2021
970c912
Removed agen pool example
lsnoddy Dec 13, 2021
c636da2
Push updated Readme file(s)
Dec 13, 2021
1596243
Restored file
lsnoddy Dec 13, 2021
b7c8cc6
Added missing network firewall policies link
lsnoddy Dec 13, 2021
e6f9847
Revert "Push updated Readme file(s)"
lsnoddy Dec 13, 2021
0d32209
Moved managedCluster reference down to agent pool resource section
lsnoddy Dec 13, 2021
c0aecda
Push updated Readme file(s)
Dec 13, 2021
158971b
Revert "Push updated Readme file(s)"
lsnoddy Dec 13, 2021
cf73a0c
Merge branch 'main' into main
lsnoddy Dec 14, 2021
86d2ba8
Push updated Readme file(s)
Dec 14, 2021
39782ce
Revert "Push updated Readme file(s)"
lsnoddy Dec 15, 2021
f125926
Update arm/Microsoft.ContainerService/managedClusters/agentPools/depl…
lsnoddy Dec 15, 2021
1ba9267
Update arm/Microsoft.ContainerService/managedClusters/agentPools/depl…
lsnoddy Dec 15, 2021
0728bff
Update arm/Microsoft.ContainerService/managedClusters/agentPools/depl…
lsnoddy Dec 15, 2021
3bbb817
Update arm/Microsoft.ContainerService/managedClusters/agentPools/depl…
lsnoddy Dec 15, 2021
79c111f
Merge branch 'Azure:main' into main
lsnoddy Dec 15, 2021
4ac2937
Merge branch 'Azure:main' into main
lsnoddy Dec 16, 2021
cf7dad0
Merge branch 'main' of https://github.com/Azure/ResourceModules into …
lsnoddy Dec 20, 2021
4d7b47b
Push updated Readme file(s)
Dec 20, 2021
eac3eda
Merge branch 'Azure:main' into main
lsnoddy Dec 20, 2021
3dceb56
Merge branch 'Azure:main' into main
lsnoddy Dec 21, 2021
695704b
Merge branch 'main' of https://github.com/Azure/ResourceModules into …
lsnoddy Feb 3, 2022
64793b9
Merge branch 'Azure-main' into main
lsnoddy Feb 3, 2022
12d91f1
Merge branch 'Azure:main' into main
lsnoddy Feb 8, 2022
4d6f040
Merge branch 'Azure:main' into main
lsnoddy Feb 9, 2022
1bdb0be
Updated bicepregistryName and namePrefix
lsnoddy Feb 9, 2022
643b158
Merge branch 'main' of https://github.com/lsnoddy/ResourceModules int…
lsnoddy Feb 9, 2022
84f3bfc
Merge branch 'Azure:main' into main
lsnoddy Feb 9, 2022
a1936cd
Added Proximity Placement Group
lsnoddy Feb 9, 2022
c54f175
default location to WestUS
lsnoddy Feb 9, 2022
f0926ed
Changed locations to westus
lsnoddy Feb 9, 2022
2098df6
Merge branch 'main' of https://github.com/Azure/ResourceModules into …
lsnoddy Feb 17, 2022
5100964
Merge branch 'Azure-main'
lsnoddy Feb 17, 2022
4401596
Merge branch 'main' of https://github.com/lsnoddy/ResourceModules
lsnoddy Feb 17, 2022
3a06177
Update settings and variables
lsnoddy Feb 17, 2022
29e4077
Updated location to EastUS
lsnoddy Feb 17, 2022
f39c19b
Updated name prefix
lsnoddy Feb 17, 2022
6cfd816
Added new min parameter test file and proximity placement group test …
lsnoddy Feb 17, 2022
c62d523
Updated route table version to 0.1
lsnoddy Feb 17, 2022
40df955
Merge pull request #6 from lsnoddy/carmlLab
lsnoddy Feb 17, 2022
509a4be
Changed version to 0.1
lsnoddy Feb 17, 2022
9cd8d23
Merge pull request #7 from lsnoddy/prereqModules
lsnoddy Feb 17, 2022
f645414
Merge branch 'Azure:main' into main
lsnoddy Feb 17, 2022
b12fb62
Merge branch 'main' of https://github.com/Azure/ResourceModules into …
lsnoddy Mar 1, 2022
d1aca8c
Merge branch 'Azure-main'
lsnoddy Mar 1, 2022
05d4fc8
Merge branch 'Azure:main' into main
lsnoddy Mar 1, 2022
6a555c3
Merge branch 'Azure:main' into main
lsnoddy Mar 1, 2022
d84c6fb
Merge branch 'Azure:main' into main
lsnoddy Mar 2, 2022
6423273
Added rbac description property
lsnoddy Mar 2, 2022
9723622
Merge branch 'Azure:main' into main
lsnoddy Mar 3, 2022
e0d728a
Merge branch 'Azure:main' into main
lsnoddy Mar 4, 2022
ec7449b
Merge branch 'Azure:main' into main
lsnoddy Mar 4, 2022
a940bd8
Added rbac description property
lsnoddy Mar 2, 2022
8e602f3
Updated readme files with rbac description property
lsnoddy Mar 4, 2022
fd8ee29
Merge branch 'Azure:main' into users/lsnoddy/rbacDescription
lsnoddy Mar 5, 2022
0a7a7f6
Merge branch 'users/lsnoddy/rbacDescription' of https://github.com/ls…
lsnoddy Mar 5, 2022
a68aa5c
Wiki restructuring - Contribution guide (#1084)
eriqua Mar 5, 2022
1b61f59
Additions to NFS fileshares (#1078)
Mar 5, 2022
c8ac629
Merge branch 'users/lsnoddy/rbacDescription' of https://github.com/ls…
lsnoddy Mar 5, 2022
934ece5
Merge branch 'Azure:main' into main
lsnoddy Mar 5, 2022
dda6346
Added rbac description property
lsnoddy Mar 2, 2022
3c85b63
Updated readme files with rbac description property
lsnoddy Mar 4, 2022
8137d5e
Merge branch 'users/lsnoddy/rbacDescription' of https://github.com/ls…
lsnoddy Mar 5, 2022
bfbe9f8
Added description property to rbac role assignment
lsnoddy Mar 7, 2022
b3c915a
Merge branch 'users/lsnoddy/rbacDescription' of https://github.com/ls…
lsnoddy Mar 9, 2022
6173b05
Reset changes that should not be merged
lsnoddy Mar 9, 2022
532bec6
Merge branch 'main' into users/lsnoddy/rbacDescription
lsnoddy Mar 9, 2022
40c27d4
Reset changes not needed for merge, corrected resourcegroup version
lsnoddy Mar 10, 2022
8bf8ae9
Reset platform.dependencies.yml file
lsnoddy Mar 10, 2022
b80c361
Removed duplicate param usage sections and edits for linter appeasement
lsnoddy Mar 10, 2022
c8c0b34
Undo version change
lsnoddy Mar 10, 2022
f45a75c
Undo version change
lsnoddy Mar 10, 2022
3a9c24e
Updated settings for testing
lsnoddy Mar 10, 2022
aec98da
Reset settings file
lsnoddy Mar 10, 2022
3fb7206
Merge branch 'main' into users/lsnoddy/rbacDescription
lsnoddy Mar 10, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
param description string = ''
param principalIds array
param roleDefinitionIdOrName string
param resourceId string
Expand Down Expand Up @@ -25,6 +26,7 @@ resource server 'Microsoft.AnalysisServices/servers@2017-08-01' existing = {
resource roleAssignment 'Microsoft.Authorization/roleAssignments@2021-04-01-preview' = [for principalId in principalIds: {
name: guid(server.name, principalId, roleDefinitionIdOrName)
properties: {
description: description
roleDefinitionId: contains(builtInRoleNames, roleDefinitionIdOrName) ? builtInRoleNames[roleDefinitionIdOrName] : roleDefinitionIdOrName
principalId: principalId
}
Expand Down
1 change: 1 addition & 0 deletions arm/Microsoft.AnalysisServices/servers/deploy.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ resource server_diagnosticSettings 'Microsoft.Insights/diagnosticsettings@2021-0
module server_rbac '.bicep/nested_rbac.bicep' = [for (roleAssignment, index) in roleAssignments: {
name: '${uniqueString(deployment().name, location)}-AnServicesServer-Rbac-${index}'
params: {
description: contains(roleAssignment, 'description') ? roleAssignment.description : ''
principalIds: roleAssignment.principalIds
roleDefinitionIdOrName: roleAssignment.roleDefinitionIdOrName
resourceId: server.id
Expand Down
1 change: 1 addition & 0 deletions arm/Microsoft.AnalysisServices/servers/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ Tag names and tag values can be provided as needed. A tag can be left without a
"value": [
{
"roleDefinitionIdOrName": "Reader",
"description": "Reader Role Assignment",
"principalIds": [
"12345678-1234-1234-1234-123456789012", // object 1
"78945612-1234-1234-1234-123456789012" // object 2
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
param description string = ''
param principalIds array
param roleDefinitionIdOrName string
param resourceId string
Expand Down Expand Up @@ -28,6 +29,7 @@ resource service 'Microsoft.ApiManagement/service@2020-12-01' existing = {
resource roleAssignment 'Microsoft.Authorization/roleAssignments@2021-04-01-preview' = [for principalId in principalIds: {
name: guid(service.name, principalId, roleDefinitionIdOrName)
properties: {
description: description
roleDefinitionId: contains(builtInRoleNames, roleDefinitionIdOrName) ? builtInRoleNames[roleDefinitionIdOrName] : roleDefinitionIdOrName
principalId: principalId
}
Expand Down
1 change: 1 addition & 0 deletions arm/Microsoft.ApiManagement/service/deploy.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,7 @@ resource apiManagementService_diagnosticSettings 'Microsoft.Insights/diagnosticS
module apiManagementService_rbac '.bicep/nested_rbac.bicep' = [for (roleAssignment, index) in roleAssignments: {
name: '${uniqueString(deployment().name, location)}-Apim-Rbac-${index}'
params: {
description: contains(roleAssignment, 'description') ? roleAssignment.description : ''
principalIds: roleAssignment.principalIds
roleDefinitionIdOrName: roleAssignment.roleDefinitionIdOrName
resourceId: apiManagementService.id
Expand Down
1 change: 1 addition & 0 deletions arm/Microsoft.ApiManagement/service/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ This module deploys an API management service.
"value": [
{
"roleDefinitionIdOrName": "Reader",
"description": "Reader Role Assignment",
"principalIds": [
"12345678-1234-1234-1234-123456789012", // object 1
"78945612-1234-1234-1234-123456789012" // object 2
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
param description string = ''
param principalIds array
param roleDefinitionIdOrName string
param resourceId string
Expand Down Expand Up @@ -29,6 +30,7 @@ resource automationAccount 'Microsoft.Automation/automationAccounts@2020-01-13-p
resource roleAssignment 'Microsoft.Authorization/roleAssignments@2021-04-01-preview' = [for principalId in principalIds: {
name: guid(automationAccount.name, principalId, roleDefinitionIdOrName)
properties: {
description: description
roleDefinitionId: contains(builtInRoleNames, roleDefinitionIdOrName) ? builtInRoleNames[roleDefinitionIdOrName] : roleDefinitionIdOrName
principalId: principalId
}
Expand Down
1 change: 1 addition & 0 deletions arm/Microsoft.Automation/automationAccounts/deploy.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,7 @@ module automationAccount_privateEndpoints '.bicep/nested_privateEndpoint.bicep'
module automationAccount_rbac '.bicep/nested_rbac.bicep' = [for (roleAssignment, index) in roleAssignments: {
name: '${uniqueString(deployment().name, location)}-AutoAccount-Rbac-${index}'
params: {
description: contains(roleAssignment, 'description') ? roleAssignment.description : ''
principalIds: roleAssignment.principalIds
roleDefinitionIdOrName: roleAssignment.roleDefinitionIdOrName
resourceId: automationAccount.id
Expand Down
1 change: 1 addition & 0 deletions arm/Microsoft.Automation/automationAccounts/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ To use Private Endpoint the following dependencies must be deployed:
"value": [
{
"roleDefinitionIdOrName": "Reader",
"description": "Reader Role Assignment",
"principalIds": [
"12345678-1234-1234-1234-123456789012", // object 1
"78945612-1234-1234-1234-123456789012" // object 2
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
param description string = ''
param principalIds array
param roleDefinitionIdOrName string
param resourceId string
Expand Down Expand Up @@ -42,6 +43,7 @@ resource account 'Microsoft.CognitiveServices/accounts@2017-04-18' existing = {
resource roleAssignment 'Microsoft.Authorization/roleAssignments@2021-04-01-preview' = [for principalId in principalIds: {
name: guid(account.name, principalId, roleDefinitionIdOrName)
properties: {
description: description
roleDefinitionId: contains(builtInRoleNames, roleDefinitionIdOrName) ? builtInRoleNames[roleDefinitionIdOrName] : roleDefinitionIdOrName
principalId: principalId
}
Expand Down
1 change: 1 addition & 0 deletions arm/Microsoft.CognitiveServices/accounts/deploy.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ module cognitiveServices_privateEndpoints '.bicep/nested_privateEndpoints.bicep'
module cognitiveServices_rbac '.bicep/nested_rbac.bicep' = [for (roleAssignment, index) in roleAssignments: {
name: '${uniqueString(deployment().name, location)}-CognitiveServices-Rbac-${index}'
params: {
description: contains(roleAssignment, 'description') ? roleAssignment.description : ''
principalIds: roleAssignment.principalIds
roleDefinitionIdOrName: roleAssignment.roleDefinitionIdOrName
resourceId: cognitiveServices.id
Expand Down
33 changes: 1 addition & 32 deletions arm/Microsoft.CognitiveServices/accounts/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ To use Private Endpoint the following dependencies must be deployed:
"value": [
{
"roleDefinitionIdOrName": "Reader",
"description": "Reader Role Assignment",
"principalIds": [
"12345678-1234-1234-1234-123456789012", // object 1
"78945612-1234-1234-1234-123456789012" // object 2
Expand All @@ -97,38 +98,6 @@ To use Private Endpoint the following dependencies must be deployed:
}
```

### Parameter Usage: `privateEndpoints`

To use Private Endpoint the following dependencies must be deployed:

- Destination subnet must be created with the following configuration option - `"privateEndpointNetworkPolicies": "Disabled"`. Setting this option acknowledges that NSG rules are not applied to Private Endpoints (this capability is coming soon). A full example is available in the Virtual Network Module.

- Although not strictly required, it is highly recommened to first create a private DNS Zone to host Private Endpoint DNS records. See [Azure Private Endpoint DNS configuration](https://docs.microsoft.com/en-us/azure/private-link/private-endpoint-dns) for more information.

```json
"privateEndpoints": {
"value": [
// Example showing all available fields
{
"name": "sxx-az-pe", // Optional: Name will be automatically generated if one is not provided here
"subnetResourceId": "/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.Network/virtualNetworks/sxx-az-vnet-x-001/subnets/sxx-az-subnet-x-001",
"service": "vault",
"privateDnsZoneResourceIds": [ // Optional: No DNS record will be created if a private DNS zone Resource ID is not specified
"/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.Network/privateDnsZones/privatelink.vaultcore.azure.net"
],
"customDnsConfigs": [ // Optional
{
"fqdn": "customname.test.local",
"ipAddresses": [
"10.10.10.10"
]
}
]
}
]
}
```

### Parameter Usage: `tags`

Tag names and tag values can be provided as needed. A tag can be left without a value.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
param description string = ''
param principalIds array
param roleDefinitionIdOrName string
param resourceId string
Expand Down Expand Up @@ -33,6 +34,7 @@ resource availabilitySet 'Microsoft.Compute/availabilitySets@2021-04-01' existin
resource roleAssignment 'Microsoft.Authorization/roleAssignments@2021-04-01-preview' = [for principalId in principalIds: {
name: guid(availabilitySet.name, principalId, roleDefinitionIdOrName)
properties: {
description: description
roleDefinitionId: contains(builtInRoleNames, roleDefinitionIdOrName) ? builtInRoleNames[roleDefinitionIdOrName] : roleDefinitionIdOrName
principalId: principalId
}
Expand Down
1 change: 1 addition & 0 deletions arm/Microsoft.Compute/availabilitySets/deploy.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ resource availabilitySet_lock 'Microsoft.Authorization/locks@2017-04-01' = if (l
module availabilitySet_rbac '.bicep/nested_rbac.bicep' = [for (roleAssignment, index) in roleAssignments: {
name: '${uniqueString(deployment().name, location)}-AvSet-Rbac-${index}'
params: {
description: contains(roleAssignment, 'description') ? roleAssignment.description : ''
principalIds: roleAssignment.principalIds
roleDefinitionIdOrName: roleAssignment.roleDefinitionIdOrName
resourceId: availabilitySet.id
Expand Down
1 change: 1 addition & 0 deletions arm/Microsoft.Compute/availabilitySets/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ This template deploys an availability set
"value": [
{
"roleDefinitionIdOrName": "Reader",
"description": "Reader Role Assignment",
"principalIds": [
"12345678-1234-1234-1234-123456789012", // object 1
"78945612-1234-1234-1234-123456789012" // object 2
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
param description string = ''
param principalIds array
param roleDefinitionIdOrName string
param resourceId string
Expand Down Expand Up @@ -31,6 +32,7 @@ resource diskEncryptionSet 'Microsoft.Compute/diskEncryptionSets@2020-12-01' exi
resource roleAssignment 'Microsoft.Authorization/roleAssignments@2021-04-01-preview' = [for principalId in principalIds: {
name: guid(diskEncryptionSet.name, principalId, roleDefinitionIdOrName)
properties: {
description: description
roleDefinitionId: contains(builtInRoleNames, roleDefinitionIdOrName) ? builtInRoleNames[roleDefinitionIdOrName] : roleDefinitionIdOrName
principalId: principalId
}
Expand Down
1 change: 1 addition & 0 deletions arm/Microsoft.Compute/diskEncryptionSets/deploy.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ module keyVaultAccessPolicies '.bicep/nested_kvAccessPolicy.bicep' = {
module diskEncryptionSet_rbac '.bicep/nested_rbac.bicep' = [for (roleAssignment, index) in roleAssignments: {
name: '${uniqueString(deployment().name, location)}-DiskEncrSet-Rbac-${index}'
params: {
description: contains(roleAssignment, 'description') ? roleAssignment.description : ''
principalIds: roleAssignment.principalIds
roleDefinitionIdOrName: roleAssignment.roleDefinitionIdOrName
resourceId: diskEncryptionSet.id
Expand Down
1 change: 1 addition & 0 deletions arm/Microsoft.Compute/diskEncryptionSets/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ This template deploys a disk encryption set.
"value": [
{
"roleDefinitionIdOrName": "Reader",
"description": "Reader Role Assignment",
"principalIds": [
"12345678-1234-1234-1234-123456789012", // object 1
"78945612-1234-1234-1234-123456789012" // object 2
Expand Down
2 changes: 2 additions & 0 deletions arm/Microsoft.Compute/disks/.bicep/nested_rbac.bicep
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
param description string = ''
param principalIds array
param roleDefinitionIdOrName string
param resourceId string
Expand Down Expand Up @@ -32,6 +33,7 @@ resource disk 'Microsoft.Compute/disks@2021-08-01' existing = {
resource roleAssignment 'Microsoft.Authorization/roleAssignments@2021-04-01-preview' = [for principalId in principalIds: {
name: guid(disk.name, principalId, roleDefinitionIdOrName)
properties: {
description: description
roleDefinitionId: contains(builtInRoleNames, roleDefinitionIdOrName) ? builtInRoleNames[roleDefinitionIdOrName] : roleDefinitionIdOrName
principalId: principalId
}
Expand Down
1 change: 1 addition & 0 deletions arm/Microsoft.Compute/disks/deploy.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ resource disk_lock 'Microsoft.Authorization/locks@2017-04-01' = if (lock != 'Not
module disk_rbac '.bicep/nested_rbac.bicep' = [for (roleAssignment, index) in roleAssignments: {
name: '${uniqueString(deployment().name, location)}-AvSet-Rbac-${index}'
params: {
description: contains(roleAssignment, 'description') ? roleAssignment.description : ''
principalIds: roleAssignment.principalIds
roleDefinitionIdOrName: roleAssignment.roleDefinitionIdOrName
resourceId: disk.id
Expand Down
4 changes: 4 additions & 0 deletions arm/Microsoft.Compute/disks/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ This template deploys a disk
| `diskIOPSReadWrite` | int | `0` | | Optional. The number of IOPS allowed for this disk; only settable for UltraSSD disks. |
| `diskMBpsReadWrite` | int | `0` | | Optional. The bandwidth allowed for this disk; only settable for UltraSSD disks. |
| `diskSizeGB` | int | `0` | | Optional. If create option is empty, this field is mandatory and it indicates the size of the disk to create. |
| `diskIOPSReadWrite` | int | `0` | | Optional. The number of IOPS allowed for this disk; only settable for UltraSSD disks. |
| `diskMBpsReadWrite` | int | `0` | | Optional. The bandwidth allowed for this disk; only settable for UltraSSD disks. |
| `diskSizeGB` | int | `0` | | Optional. If create option is empty, this field is mandatory and it indicates the size of the disk to create. |
| `enableDefaultTelemetry` | bool | `True` | | Optional. Enable telemetry via the Customer Usage Attribution ID (GUID). |
| `hyperVGeneration` | string | `V2` | `[V1, V2]` | Optional. The hypervisor generation of the Virtual Machine. Applicable to OS disks only. |
| `imageReferenceId` | string | | | Optional. A relative uri containing either a Platform Image Repository or user image reference. |
Expand Down Expand Up @@ -48,6 +51,7 @@ This template deploys a disk
"value": [
{
"roleDefinitionIdOrName": "Reader",
"description": "Reader Role Assignment",
"principalIds": [
"12345678-1234-1234-1234-123456789012", // object 1
"78945612-1234-1234-1234-123456789012" // object 2
Expand Down
2 changes: 2 additions & 0 deletions arm/Microsoft.Compute/galleries/.bicep/nested_rbac.bicep
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
param description string = ''
param principalIds array
param roleDefinitionIdOrName string
param resourceId string
Expand Down Expand Up @@ -27,6 +28,7 @@ resource gallery 'Microsoft.Compute/galleries@2020-09-30' existing = {
resource roleAssignment 'Microsoft.Authorization/roleAssignments@2021-04-01-preview' = [for principalId in principalIds: {
name: guid(gallery.name, principalId, roleDefinitionIdOrName)
properties: {
description: description
roleDefinitionId: contains(builtInRoleNames, roleDefinitionIdOrName) ? builtInRoleNames[roleDefinitionIdOrName] : roleDefinitionIdOrName
principalId: principalId
}
Expand Down
1 change: 1 addition & 0 deletions arm/Microsoft.Compute/galleries/deploy.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ resource gallery_lock 'Microsoft.Authorization/locks@2017-04-01' = if (lock != '
module gallery_rbac '.bicep/nested_rbac.bicep' = [for (roleAssignment, index) in roleAssignments: {
name: '${uniqueString(deployment().name, location)}-Gallery-Rbac-${index}'
params: {
description: contains(roleAssignment, 'description') ? roleAssignment.description : ''
principalIds: roleAssignment.principalIds
roleDefinitionIdOrName: roleAssignment.roleDefinitionIdOrName
resourceId: gallery.id
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
param description string = ''
param principalIds array
param roleDefinitionIdOrName string
param resourceId string
Expand Down Expand Up @@ -29,6 +30,7 @@ resource galleryImage 'Microsoft.Compute/galleries/images@2020-09-30' existing =
resource roleAssignment 'Microsoft.Authorization/roleAssignments@2021-04-01-preview' = [for principalId in principalIds: {
name: guid(galleryImage.name, principalId, roleDefinitionIdOrName)
properties: {
description: description
roleDefinitionId: contains(builtInRoleNames, roleDefinitionIdOrName) ? builtInRoleNames[roleDefinitionIdOrName] : roleDefinitionIdOrName
principalId: principalId
}
Expand Down
1 change: 1 addition & 0 deletions arm/Microsoft.Compute/galleries/images/deploy.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ resource image 'Microsoft.Compute/galleries/images@2020-09-30' = {
module galleryImage_rbac '.bicep/nested_rbac.bicep' = [for (roleAssignment, index) in roleAssignments: {
name: '${deployment().name}-Rbac-${index}'
params: {
description: contains(roleAssignment, 'description') ? roleAssignment.description : ''
principalIds: roleAssignment.principalIds
roleDefinitionIdOrName: roleAssignment.roleDefinitionIdOrName
resourceId: image.id
Expand Down
1 change: 1 addition & 0 deletions arm/Microsoft.Compute/galleries/images/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ This module deploys an Image Definition in a Shared Image Gallery.
"value": [
{
"roleDefinitionIdOrName": "Reader",
"description": "Reader Role Assignment",
"principalIds": [
"12345678-1234-1234-1234-123456789012", // object 1
"78945612-1234-1234-1234-123456789012" // object 2
Expand Down
1 change: 1 addition & 0 deletions arm/Microsoft.Compute/galleries/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ This module deploys an Azure compute gallery (formerly known as shared image gal
"value": [
{
"roleDefinitionIdOrName": "Reader",
"description": "Reader Role Assignment",
"principalIds": [
"12345678-1234-1234-1234-123456789012", // object 1
"78945612-1234-1234-1234-123456789012" // object 2
Expand Down
2 changes: 2 additions & 0 deletions arm/Microsoft.Compute/images/.bicep/nested_rbac.bicep
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
param description string = ''
param principalIds array
param roleDefinitionIdOrName string
param resourceId string
Expand Down Expand Up @@ -29,6 +30,7 @@ resource image 'Microsoft.Compute/images@2021-04-01' existing = {
resource roleAssignment 'Microsoft.Authorization/roleAssignments@2021-04-01-preview' = [for principalId in principalIds: {
name: guid(image.name, principalId, roleDefinitionIdOrName)
properties: {
description: description
roleDefinitionId: contains(builtInRoleNames, roleDefinitionIdOrName) ? builtInRoleNames[roleDefinitionIdOrName] : roleDefinitionIdOrName
principalId: principalId
}
Expand Down
1 change: 1 addition & 0 deletions arm/Microsoft.Compute/images/deploy.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ resource image 'Microsoft.Compute/images@2021-04-01' = {
module image_rbac '.bicep/nested_rbac.bicep' = [for (roleAssignment, index) in roleAssignments: {
name: '${uniqueString(deployment().name, location)}-Image-Rbac-${index}'
params: {
description: contains(roleAssignment, 'description') ? roleAssignment.description : ''
principalIds: roleAssignment.principalIds
roleDefinitionIdOrName: roleAssignment.roleDefinitionIdOrName
resourceId: image.id
Expand Down
1 change: 1 addition & 0 deletions arm/Microsoft.Compute/images/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ This module deploys a compute image.
"value": [
{
"roleDefinitionIdOrName": "Reader",
"description": "Reader Role Assignment",
"principalIds": [
"12345678-1234-1234-1234-123456789012", // object 1
"78945612-1234-1234-1234-123456789012" // object 2
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
param description string = ''
param principalIds array
param roleDefinitionIdOrName string
param resourceId string
Expand Down Expand Up @@ -31,6 +32,7 @@ resource proximityPlacementGroup 'Microsoft.Compute/proximityPlacementGroups@202
resource roleAssignment 'Microsoft.Authorization/roleAssignments@2021-04-01-preview' = [for principalId in principalIds: {
name: guid(proximityPlacementGroup.name, principalId, roleDefinitionIdOrName)
properties: {
description: description
roleDefinitionId: contains(builtInRoleNames, roleDefinitionIdOrName) ? builtInRoleNames[roleDefinitionIdOrName] : roleDefinitionIdOrName
principalId: principalId
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ resource proximityPlacementGroup_lock 'Microsoft.Authorization/locks@2017-04-01'
module proximityPlacementGroup_rbac '.bicep/nested_rbac.bicep' = [for (roleAssignment, index) in roleAssignments: {
name: '${uniqueString(deployment().name, location)}-ProxPlaceGroup-Rbac-${index}'
params: {
description: contains(roleAssignment, 'description') ? roleAssignment.description : ''
principalIds: roleAssignment.principalIds
roleDefinitionIdOrName: roleAssignment.roleDefinitionIdOrName
resourceId: proximityPlacementGroup.id
Expand Down
1 change: 1 addition & 0 deletions arm/Microsoft.Compute/proximityPlacementGroups/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ This template deploys a proximity placement group.
"value": [
{
"roleDefinitionIdOrName": "Reader",
"description": "Reader Role Assignment",
"principalIds": [
"12345678-1234-1234-1234-123456789012", // object 1
"78945612-1234-1234-1234-123456789012" // object 2
Expand Down
Loading