Skip to content

RBAC Role Assignments: Added description parameter#1115

Merged
AlexanderSehr merged 203 commits intoAzure:mainfrom
lsnoddy:users/lsnoddy/rbacDescription
Mar 11, 2022
Merged

RBAC Role Assignments: Added description parameter#1115
AlexanderSehr merged 203 commits intoAzure:mainfrom
lsnoddy:users/lsnoddy/rbacDescription

Conversation

@lsnoddy
Copy link
Copy Markdown
Member

@lsnoddy lsnoddy commented Mar 9, 2022 •
edited
Loading

Change

  • Added a description parameter to the nested_rbac module which provides an optional description for rbac role assignments. Added the parameter to all modules using the nested_rbac.bicep module.
  • Updated the resourceUsage-roleAssignments.md helper template with an example of this parameter and refreshed all the readme files which also included some parameter default value updates in readme files that were un-related to this change.

ApiManagement: Service

AnalysisServices: Servers

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

lsnoddy and others added 30 commits November 15, 2021 17:30
@lsnoddy
Update to new child-resource structure progress
30d0ec1
@lsnoddy
Merge branch 'main' of https://github.com/lsnoddy/ResourceModules int…
7b8ea9f 
…o main
@lsnoddy
Progress check-in
e725966
@lsnoddy
Added managed cluster name parameter
0454fa2
@lsnoddy
Updated readme
aad50a9
@lsnoddy
Merge branch 'Azure:main' into main
8e3f37e
@lsnoddy
Updated readme file
eb9ac8f
@lsnoddy
Updated readme
4895bfd
Push updated Readme file(s)
a24964d
@lsnoddy
Updated readme
9da3646
@lsnoddy
Merge branch 'main' of https://github.com/lsnoddy/ResourceModules
3ccc8dd
@lsnoddy
Added test param file
4210ecf
@lsnoddy
Updated subscriptionId
4ce1e3b
@lsnoddy
Added test param file
a9726f6
@lsnoddy
Removed subscription id
ed984d6
@lsnoddy
Modified test variables
0380167
@lsnoddy
Modified test variables
ecf407a
@lsnoddy
Test dependency values
40ffa48
@lsnoddy
Updated parameters
f03ac3a
@lsnoddy
Removed local files used for testing
d056b74
@lsnoddy
Merge branch 'Azure:main' into main
8f3447b
@lsnoddy
Updated readme
a792c19
@lsnoddy
Merge branch 'main' of https://github.com/lsnoddy/ResourceModules
d128feb
@lsnoddy
Updated readme
cc8c087
@lsnoddy
Revert "Push updated Readme file(s)"
30a00ca 
This reverts commit a24964d.
@lsnoddy
Updated readme
20a3955
@lsnoddy
Updated both readme files and agentPool paramter name consistency
5139c68
Push updated Readme file(s)
39ae6ce
@lsnoddy
Merge branch 'Azure:main' into main
20c6a88
@lsnoddy
Updated Api to API to appease linter
5621dcb
lsnoddy and others added 14 commits March 4, 2022 15:27
@lsnoddy
Added rbac description property
a940bd8
@lsnoddy
Updated readme files with rbac description property
8e602f3
@lsnoddy
Merge branch 'Azure:main' into users/lsnoddy/rbacDescription
fd8ee29
@lsnoddy
Merge branch 'users/lsnoddy/rbacDescription' of https://github.com/ls…
0a7a7f6 
…noddy/ResourceModules into users/lsnoddy/rbacDescription
@eriqua @lsnoddy
Wiki restructuring - Contribution guide (Azure#1084)
a68aa5c 
* utilities

* contribution flow

* contribution env setup

* validate

* validate

* home index

* contrib flow full

* assignee
@lsnoddy
Additions to NFS fileshares (Azure#1078)
1b61f59 
* Added link between NFS fileshare and fileserivces
* Added test case for NFS4.1
@lsnoddy
Merge branch 'users/lsnoddy/rbacDescription' of https://github.com/ls…
c8ac629 
…noddy/ResourceModules into users/lsnoddy/rbacDescription
@lsnoddy
Merge branch 'Azure:main' into main
934ece5
@lsnoddy
Added rbac description property
dda6346
@lsnoddy
Updated readme files with rbac description property
3c85b63
@lsnoddy
Merge branch 'users/lsnoddy/rbacDescription' of https://github.com/ls…
8137d5e 
…noddy/ResourceModules into users/lsnoddy/rbacDescription
@lsnoddy
Added description property to rbac role assignment
bfbe9f8
@lsnoddy
Merge branch 'users/lsnoddy/rbacDescription' of https://github.com/ls…
b3c915a 
…noddy/ResourceModules into users/lsnoddy/rbacDescription
@lsnoddy
Reset changes that should not be merged
6173b05
@lsnoddy lsnoddy added [cat] modules category: modules enhancement New feature or request labels Mar 9, 2022
@lsnoddy lsnoddy marked this pull request as ready for review March 10, 2022 21:45
@lsnoddy lsnoddy linked an issue Mar 10, 2022 that may be closed by this pull request
Add description property to RBAC #1035
Closed
@AlexanderSehr AlexanderSehr merged commit ad8b840 into Azure:main Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rahalan rahalan rahalan approved these changes

Assignees

@lsnoddy lsnoddy

Labels

[cat] modules category: modules enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add description property to RBAC

4 participants

@lsnoddy @rahalan @AlexanderSehr @eriqua