Skip to content

Enabling NFS 4.1 Fileshares#1078

Merged
MariusStorhaug merged 4 commits intomainfrom
users/mast/SA_NFS
Mar 5, 2022
Merged

Enabling NFS 4.1 Fileshares#1078
MariusStorhaug merged 4 commits intomainfrom
users/mast/SA_NFS

Conversation

@MariusStorhaug
Copy link
Copy Markdown
Contributor

@MariusStorhaug MariusStorhaug commented Mar 4, 2022 •
edited
Loading

Change

Adding support for NFS 4.1 file shares

Storage: StorageAccounts

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 4, 2022 •
edited
Loading

Unit Test Results

    1 files  ±    0    1 suites  ±0   2m 9s ⏱️ + 1m 33s
  42 tests +  37  42 ✔️ +37      0 💤 ±    0  0 ❌ ±0 
387 runs  +287  42 ✔️ +37  345 💤 +250  0 ❌ ±0 

Results for commit 4ce0c23. ± Comparison against base commit 3bd8c62.

This pull request removes 5 and adds 42 tests. Note that renamed tests count towards both. 
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/virtualHubs/hubRouteTables] used resource type [virtualHubs/hubRouteTables] should use on of the recent API version(s). Currently using [2021-05-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/virtualHubs/hubVirtualNetworkConnections] used resource type [virtualHubs/hubVirtualNetworkConnections] should use on of the recent API version(s). Currently using [2021-05-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/virtualHubs] used resource type [virtualHubs/hubRouteTables] should use on of the recent API version(s). Currently using [2021-05-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/virtualHubs] used resource type [virtualHubs/hubVirtualNetworkConnections] should use on of the recent API version(s). Currently using [2021-05-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/virtualHubs] used resource type [virtualHubs] should use on of the recent API version(s). Currently using [2021-05-01]

/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices/containers/immutabilityPolicies] used resource type [storageAccounts/blobServices/containers/immutabilityPolicies] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices/containers] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices/containers] used resource type [storageAccounts/blobServices/containers/immutabilityPolicies] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices/containers] used resource type [storageAccounts/blobServices/containers] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices] used resource type [storageAccounts/blobServices/containers/immutabilityPolicies] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices] used resource type [storageAccounts/blobServices/containers] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices] used resource type [storageAccounts/blobServices] should use on of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/fileServices/shares] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]
…

♻️ This comment has been updated with latest results.

@MariusStorhaug MariusStorhaug marked this pull request as ready for review March 4, 2022 17:58
@MariusStorhaug MariusStorhaug enabled auto-merge (squash) March 4, 2022 18:08
@MariusStorhaug MariusStorhaug changed the title Additions to NFS fileshares Enabling NFS 4.1 Fileshares Mar 4, 2022
@MariusStorhaug MariusStorhaug requested review from AlexanderSehr, eriqua and rahalan and removed request for AlexanderSehr and eriqua March 4, 2022 18:19
@MariusStorhaug MariusStorhaug self-assigned this Mar 4, 2022
@MariusStorhaug MariusStorhaug merged commit d7e565c into main Mar 5, 2022
@MariusStorhaug MariusStorhaug deleted the users/mast/SA_NFS branch March 5, 2022 16:10
lsnoddy pushed a commit to lsnoddy/ResourceModules that referenced this pull request Mar 5, 2022
@lsnoddy
Additions to NFS fileshares (Azure#1078)
1b61f59 
* Added link between NFS fileshare and fileserivces
* Added test case for NFS4.1
AlexanderSehr added a commit that referenced this pull request Mar 11, 2022
@lsnoddy @AlexanderSehr @eriqua
RBAC Role Assignments: Added description parameter (#1115)
ad8b840 
* Update to new child-resource structure progress

* Progress check-in

* Added managed cluster name parameter

* Updated readme

* Updated readme file

* Updated readme

* Push updated Readme file(s)

* Updated readme

* Added test param file

* Updated subscriptionId

* Added test param file

* Removed subscription id

* Modified test variables

* Modified test variables

* Test dependency values

* Updated parameters

* Removed local files used for testing

* Updated readme

* Updated readme

* Revert "Push updated Readme file(s)"

This reverts commit a24964d.

* Updated readme

* Updated both readme files and agentPool paramter name consistency

* Push updated Readme file(s)

* Updated Api to API to appease linter

* Revert "Push updated Readme file(s)"

This reverts commit 39ae6ce.

* Reverted inadvertent readme change

* Updated agentPool param description

* Push updated Readme file(s)

* Revert "Push updated Readme file(s)"

This reverts commit c0bd1e1.

* Nodepools one word per linter error

* Push updated Readme file(s)

* Updated agentPool parameter name

* Updated agentPools parameter name

* Revert "Push updated Readme file(s)"

This reverts commit c3eb913.

* Push updated Readme file(s)

* Added parameters for all agentPool properties

* Updated name parameter

* Added required systemAssignedIdentity param for testing

* Added type parameter

* Updated containerLogMaxFiles

* Updated containerLogMaxFiles

* Updated cpuManagerPolicy param

* Updated image high and image low threshold params

* Updated topologyManagerPolicy param

* Updated transparentHugePageDefrag and transparentHugePageEnabled

* Updated osType parameter

* Updated proximityPlacementGroupID

* Updated proximityPlacementGroupId

* proximityPlacementGroupId test

* Updated parameter default values

* Updated nodePublicIpPrefixId param

* Updated nodePublicIpPrefixId

* Updated string values with null when empty

* Ucommented proximiytPlacementGroupId

* Added default vm size

* Change maxPods default to 10

* Changed maxPods default

* Param default mgmt

* Update osDiskType default

* Set osSKU default

* Updated parameters

* Updated sourceResourceId parameter default

* Updated sourceResourceId

* Updated creationData variable

* Comment out creationData - test

* Updated gpuInstanceProfile

* Updated gpu instance profile

* Updated osDiskType

* Updated sourceResourceId

* Updated sourceResourceId

* Updated conatinerLog params

* Updated containerLogMaxFiles

* Updated swapFileSize param

* swap file size update

* Updated swapFileSize

* Updated netCoreSomaxconn

* Updated netcoreSomaxconn param

* Updated netCoreNetdevMaxBacklog param

* Updated netCoreRmemDefault param

* Updated netCoreOptmemMax

* Updated netCoreWmemDefault param

* Updated netCoreWmemMax

* Update netCoreWmemMax param

* Updated netCoreOptmemMax param

* Updated netIpv4TcpMaxSynBacklog param

* Updated netIpv4TcpMaxTwBuckets param

* Update  netIpv4TcpFinTimeout param

* Update etIpv4TcpKeepaliveTime param

* Updated netIpv4TcpKeepaliveProbes

* Updated netIpv4TcpkeepaliveIntvl param

* Updated netIpv4NeighDefaultGcThresholds params

* Updated netIpv4NeighDefaultGcThresh2

* Updated Sysctl settings

* Removed unneccessary properties object

* Registry name test

* Updated readme files

* Updated parameter files for new agentpool format

* Updated readme files

* Update platform dependencies

* Updates

* Updated readme

* Updated readme

* Updated readme

* Revert "Update platform dependencies"

This reverts commit 55df214.

* Update

* Update

* Restore file

* Restore file

* Test restore

* Test revert

* Restore file

* Updated

* Removed agentPool example

* Removed extra spaces and changed comparison to not equal

* Removed agen pool example

* Push updated Readme file(s)

* Restored file

* Added missing network firewall policies link

* Revert "Push updated Readme file(s)"

This reverts commit c636da2.

* Moved managedCluster reference down to agent pool resource section

* Push updated Readme file(s)

* Revert "Push updated Readme file(s)"

This reverts commit c0aecda.

* Push updated Readme file(s)

* Revert "Push updated Readme file(s)"

This reverts commit 86d2ba8.

* Update arm/Microsoft.ContainerService/managedClusters/agentPools/deploy.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update arm/Microsoft.ContainerService/managedClusters/agentPools/deploy.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update arm/Microsoft.ContainerService/managedClusters/agentPools/deploy.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update arm/Microsoft.ContainerService/managedClusters/agentPools/deploy.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Push updated Readme file(s)

* Updated bicepregistryName and namePrefix

* Added Proximity Placement Group

* default location to WestUS

* Changed locations to westus

* Update settings and variables

* Updated location to EastUS

* Updated name prefix

* Added new min parameter test file and proximity placement group test to availability set module

* Updated route table version to 0.1

* Changed version to 0.1

* Added rbac description property

* Added rbac description property

* Updated readme files with rbac description property

* Wiki restructuring - Contribution guide (#1084)

* utilities

* contribution flow

* contribution env setup

* validate

* validate

* home index

* contrib flow full

* assignee

* Additions to NFS fileshares (#1078)

* Added link between NFS fileshare and fileserivces
* Added test case for NFS4.1

* Added rbac description property

* Updated readme files with rbac description property

* Added description property to rbac role assignment

* Reset changes that should not be merged

* Reset changes not needed for merge, corrected resourcegroup version

* Reset platform.dependencies.yml file

* Removed duplicate param usage sections and edits for linter appeasement

* Undo version change

* Undo version change

* Updated settings for testing

* Reset settings file

Co-authored-by: CARMLPipelinePrincipal <CARML@noreply.github.com>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

@rahalan rahalan Awaiting requested review from rahalan

@eriqua eriqua Awaiting requested review from eriqua

Assignees

@MariusStorhaug MariusStorhaug

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MariusStorhaug @AlexanderSehr