Wiki restructuring - Contribution guide#1084
Merged
MariusStorhaug merged 9 commits intomainfrom Mar 5, 2022
Merged
Conversation
MariusStorhaug
approved these changes
Mar 5, 2022
lsnoddy
pushed a commit
to lsnoddy/ResourceModules
that referenced
this pull request
Mar 5, 2022
* utilities * contribution flow * contribution env setup * validate * validate * home index * contrib flow full * assignee
AlexanderSehr
added a commit
that referenced
this pull request
Mar 11, 2022
* Update to new child-resource structure progress * Progress check-in * Added managed cluster name parameter * Updated readme * Updated readme file * Updated readme * Push updated Readme file(s) * Updated readme * Added test param file * Updated subscriptionId * Added test param file * Removed subscription id * Modified test variables * Modified test variables * Test dependency values * Updated parameters * Removed local files used for testing * Updated readme * Updated readme * Revert "Push updated Readme file(s)" This reverts commit a24964d. * Updated readme * Updated both readme files and agentPool paramter name consistency * Push updated Readme file(s) * Updated Api to API to appease linter * Revert "Push updated Readme file(s)" This reverts commit 39ae6ce. * Reverted inadvertent readme change * Updated agentPool param description * Push updated Readme file(s) * Revert "Push updated Readme file(s)" This reverts commit c0bd1e1. * Nodepools one word per linter error * Push updated Readme file(s) * Updated agentPool parameter name * Updated agentPools parameter name * Revert "Push updated Readme file(s)" This reverts commit c3eb913. * Push updated Readme file(s) * Added parameters for all agentPool properties * Updated name parameter * Added required systemAssignedIdentity param for testing * Added type parameter * Updated containerLogMaxFiles * Updated containerLogMaxFiles * Updated cpuManagerPolicy param * Updated image high and image low threshold params * Updated topologyManagerPolicy param * Updated transparentHugePageDefrag and transparentHugePageEnabled * Updated osType parameter * Updated proximityPlacementGroupID * Updated proximityPlacementGroupId * proximityPlacementGroupId test * Updated parameter default values * Updated nodePublicIpPrefixId param * Updated nodePublicIpPrefixId * Updated string values with null when empty * Ucommented proximiytPlacementGroupId * Added default vm size * Change maxPods default to 10 * Changed maxPods default * Param default mgmt * Update osDiskType default * Set osSKU default * Updated parameters * Updated sourceResourceId parameter default * Updated sourceResourceId * Updated creationData variable * Comment out creationData - test * Updated gpuInstanceProfile * Updated gpu instance profile * Updated osDiskType * Updated sourceResourceId * Updated sourceResourceId * Updated conatinerLog params * Updated containerLogMaxFiles * Updated swapFileSize param * swap file size update * Updated swapFileSize * Updated netCoreSomaxconn * Updated netcoreSomaxconn param * Updated netCoreNetdevMaxBacklog param * Updated netCoreRmemDefault param * Updated netCoreOptmemMax * Updated netCoreWmemDefault param * Updated netCoreWmemMax * Update netCoreWmemMax param * Updated netCoreOptmemMax param * Updated netIpv4TcpMaxSynBacklog param * Updated netIpv4TcpMaxTwBuckets param * Update netIpv4TcpFinTimeout param * Update etIpv4TcpKeepaliveTime param * Updated netIpv4TcpKeepaliveProbes * Updated netIpv4TcpkeepaliveIntvl param * Updated netIpv4NeighDefaultGcThresholds params * Updated netIpv4NeighDefaultGcThresh2 * Updated Sysctl settings * Removed unneccessary properties object * Registry name test * Updated readme files * Updated parameter files for new agentpool format * Updated readme files * Update platform dependencies * Updates * Updated readme * Updated readme * Updated readme * Revert "Update platform dependencies" This reverts commit 55df214. * Update * Update * Restore file * Restore file * Test restore * Test revert * Restore file * Updated * Removed agentPool example * Removed extra spaces and changed comparison to not equal * Removed agen pool example * Push updated Readme file(s) * Restored file * Added missing network firewall policies link * Revert "Push updated Readme file(s)" This reverts commit c636da2. * Moved managedCluster reference down to agent pool resource section * Push updated Readme file(s) * Revert "Push updated Readme file(s)" This reverts commit c0aecda. * Push updated Readme file(s) * Revert "Push updated Readme file(s)" This reverts commit 86d2ba8. * Update arm/Microsoft.ContainerService/managedClusters/agentPools/deploy.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update arm/Microsoft.ContainerService/managedClusters/agentPools/deploy.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update arm/Microsoft.ContainerService/managedClusters/agentPools/deploy.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update arm/Microsoft.ContainerService/managedClusters/agentPools/deploy.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Push updated Readme file(s) * Updated bicepregistryName and namePrefix * Added Proximity Placement Group * default location to WestUS * Changed locations to westus * Update settings and variables * Updated location to EastUS * Updated name prefix * Added new min parameter test file and proximity placement group test to availability set module * Updated route table version to 0.1 * Changed version to 0.1 * Added rbac description property * Added rbac description property * Updated readme files with rbac description property * Wiki restructuring - Contribution guide (#1084) * utilities * contribution flow * contribution env setup * validate * validate * home index * contrib flow full * assignee * Additions to NFS fileshares (#1078) * Added link between NFS fileshare and fileserivces * Added test case for NFS4.1 * Added rbac description property * Updated readme files with rbac description property * Added description property to rbac role assignment * Reset changes that should not be merged * Reset changes not needed for merge, corrected resourcegroup version * Reset platform.dependencies.yml file * Removed duplicate param usage sections and edits for linter appeasement * Undo version change * Undo version change * Updated settings for testing * Reset settings file Co-authored-by: CARMLPipelinePrincipal <CARML@noreply.github.com> Co-authored-by: Alexander Sehr <ASehr@hotmail.de> Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com> Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Contribution guide
Type of Change
Please delete options that are not relevant.
Checklist