Skip to content

[Modules] Allowed User assigned identity deployments#1361

Merged
ahmadabdalla merged 3 commits intomainfrom
users/ahmad/policyAssignment_UMI
May 5, 2022
Merged

[Modules] Allowed User assigned identity deployments#1361
ahmadabdalla merged 3 commits intomainfrom
users/ahmad/policyAssignment_UMI

Conversation

@ahmadabdalla
Copy link
Copy Markdown
Contributor

Description

Closes #1360

Enables User assigned identity support for a policy assignment.

Note: This will not trigger the 'role assignment' resource creation object as it is assumed that a user identity will have the permissions required to modify resources. Hence the role assignment will only run if the policy is using a system assigned identity.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline Run
policy assignment Authorization: PolicyAssignments

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added the enhancement New feature or request label May 4, 2022
@ahmadabdalla ahmadabdalla self-assigned this May 4, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 4, 2022

Unit Test Results

    1 files  ±    0  1 suites  ±0   22s ⏱️ -35s
    8 tests  -   22  8 ✔️  - 22      0 💤 ±    0  0 ±0 
130 runs   - 192  8 ✔️  - 22  122 💤  - 170  0 ±0 

Results for commit 08424ee. ± Comparison against base commit a443c7f.

This pull request removes 30 and adds 8 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceBus/namespaces/authorizationRules] used resource type [namespaces/AuthorizationRules] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceBus/namespaces/disasterRecoveryConfigs] used resource type [namespaces/disasterRecoveryConfigs] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceBus/namespaces/ipFilterRules] used resource type [namespaces/ipfilterrules] should use one of the recent API version(s). Currently using [2018-01-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceBus/namespaces/migrationConfigurations] used resource type [namespaces/migrationConfigurations] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceBus/namespaces/queues/authorizationRules] used resource type [namespaces/queues/authorizationRules] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceBus/namespaces/queues] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceBus/namespaces/queues] used resource type [namespaces/queues/authorizationRules] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceBus/namespaces/queues] used resource type [namespaces/queues] should use one of the recent API version(s). Currently using [2021-06-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceBus/namespaces/queues] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2020-10-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceBus/namespaces/topics/authorizationRules] used resource type [namespaces/topics/authorizationRules] should use one of the recent API version(s). Currently using [2021-06-01-preview]
…
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Authorization/policyAssignments/managementGroup] used resource type [policyAssignments] should use one of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Authorization/policyAssignments/managementGroup] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2020-10-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Authorization/policyAssignments/resourceGroup] used resource type [policyAssignments] should use one of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Authorization/policyAssignments/resourceGroup] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2020-10-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Authorization/policyAssignments/subscription] used resource type [policyAssignments] should use one of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Authorization/policyAssignments/subscription] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2020-10-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Authorization/policyAssignments] used resource type [policyAssignments] should use one of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Authorization/policyAssignments] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2020-10-01-preview]

♻️ This comment has been updated with latest results.

@ahmadabdalla ahmadabdalla marked this pull request as ready for review May 5, 2022 06:48
@ahmadabdalla ahmadabdalla merged commit 4c31bf2 into main May 5, 2022
@ahmadabdalla ahmadabdalla deleted the users/ahmad/policyAssignment_UMI branch May 5, 2022 12:13
@AlexanderSehr AlexanderSehr changed the title allowed User assigned identity deployments [Modules] Allowed User assigned identity deployments Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Support User Assigned Identity for Policy Assignment

3 participants