Skip to content

[Modules] Cross-Module references#1401

Merged
AlexanderSehr merged 89 commits intomainfrom
users/alsehr/905_poc
May 29, 2022
Merged

[Modules] Cross-Module references#1401
AlexanderSehr merged 89 commits intomainfrom
users/alsehr/905_poc

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented May 17, 2022

Description

  • First PoC for the cross-module references
  • For example
    • Private Endpoint
    • Public IP
    • NIC
    • ProtectedItems
  • Created utilities to visualize demands (local/remote)
    • Get-LinkedModuleList.ps1
    • Get-LinkedLocalModuleList.ps1
  • Moved protectedItem from VM module to RSV module
  graph LR;
    configurationStores["Microsoft.AppConfiguration/configurationStores"] --> privateEndpoints["Microsoft.Network/privateEndpoints"];
    privateLinkHubs["Microsoft.Synapse/privateLinkHubs"] --> privateEndpoints["Microsoft.Network/privateEndpoints"];
    sites["Microsoft.Web/sites"] --> privateEndpoints["Microsoft.Network/privateEndpoints"];
    vaults["Microsoft.KeyVault/vaults"] --> privateEndpoints["Microsoft.Network/privateEndpoints"];
    servers["Microsoft.Sql/servers"] --> privateEndpoints["Microsoft.Network/privateEndpoints"];
    systemTopics["Microsoft.EventGrid/systemTopics"] --> privateEndpoints["Microsoft.Network/privateEndpoints"];
    accounts["Microsoft.CognitiveServices/accounts"] --> privateEndpoints["Microsoft.Network/privateEndpoints"];
    workspaces["Microsoft.MachineLearningServices/workspaces"] --> privateEndpoints["Microsoft.Network/privateEndpoints"];
    registries["Microsoft.ContainerRegistry/registries"] --> privateEndpoints["Microsoft.Network/privateEndpoints"];
    namespaces["Microsoft.ServiceBus/namespaces"] --> privateEndpoints["Microsoft.Network/privateEndpoints"];
    storageAccounts["Microsoft.Storage/storageAccounts"] --> privateEndpoints["Microsoft.Network/privateEndpoints"];
    privateLinkScopes["Microsoft.Insights/privateLinkScopes"] --> privateEndpoints["Microsoft.Network/privateEndpoints"];
    virtualMachines["Microsoft.Compute/virtualMachines"] --> protectedItems["Microsoft.RecoveryServices/vaults/protectionContainers/protectedItems"];
    virtualMachines["Microsoft.Compute/virtualMachines"] --> networkInterfaces["Microsoft.Network/networkInterfaces"];
    virtualMachines["Microsoft.Compute/virtualMachines"] --> publicIPAddresses["Microsoft.Network/publicIPAddresses"];
    bastionHosts["Microsoft.Network/bastionHosts"] --> publicIPAddresses["Microsoft.Network/publicIPAddresses"];
Loading

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: BastionHosts
AppConfiguration: ConfigurationStores
Synapse: PrivateLinkHubs
Web: Sites
KeyVault: Vaults
Sql: Servers
EventGrid: System Topics
CognitiveServices: Accounts
MachineLearningServices: Workspaces
ContainerRegistry: Registries
ServiceBus: Namespaces
Storage: StorageAccounts
Insights: PrivateLinkScopes
Compute: VirtualMachines <- unrelated issue in main
Network: PrivateEndpoints

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@AlexanderSehr AlexanderSehr marked this pull request as draft May 17, 2022 12:49
@AlexanderSehr AlexanderSehr self-assigned this May 17, 2022
@AlexanderSehr AlexanderSehr linked an issue May 17, 2022 that may be closed by this pull request
@AlexanderSehr AlexanderSehr added documentation Improvements or additions to documentation enhancement New feature or request [cat] modules category: modules labels May 17, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 17, 2022

Unit Test Results

1 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 063f847. ± Comparison against base commit c750f22.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr disabled auto-merge May 27, 2022 19:27
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) May 27, 2022 19:28
Copy link
Copy Markdown
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First set of feedback

AlexanderSehr and others added 6 commits May 30, 2022 00:19
…erface.bicep

Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
Co-authored-by: Marius Storhaug <Marius.Storhaug@microsoft.com>
@AlexanderSehr AlexanderSehr merged commit 4218f7c into main May 29, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/905_poc branch May 29, 2022 22:22
@eriqua eriqua mentioned this pull request Jun 15, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report]: EventGrid System Topics can't use private endpoints PoC Module inter-dependency

4 participants