Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
89 commits
Select commit Hold shift + click to select a range
ca89185
Updated private endpoint default + cross referenced it from kvlt
AlexanderSehr May 14, 2022
8714b57
Updated more private endpoint references
AlexanderSehr May 14, 2022
84af966
Updated further endpoints
AlexanderSehr May 15, 2022
73c7eae
Updated VM
AlexanderSehr May 15, 2022
986334b
Further reducation
AlexanderSehr May 16, 2022
07df868
Further updates
AlexanderSehr May 16, 2022
22b6dde
Update to latest
AlexanderSehr May 16, 2022
a7afd0c
Update to latest
AlexanderSehr May 16, 2022
dd02fc0
Update to latest
AlexanderSehr May 16, 2022
c0f6e9d
Moved protected item
AlexanderSehr May 16, 2022
e76caac
Minor fi
AlexanderSehr May 16, 2022
e6e8acf
Update to latest
AlexanderSehr May 16, 2022
b3f8964
Fixed missing check
AlexanderSehr May 17, 2022
2d427e3
Resolved conflicts
AlexanderSehr May 17, 2022
8b4b324
Update to latest
AlexanderSehr May 17, 2022
9a5c593
Updated readme
AlexanderSehr May 17, 2022
2e6a846
Minor fix
AlexanderSehr May 17, 2022
c9e4a54
Adjusted name gen to original
AlexanderSehr May 17, 2022
0b0485f
Changed pip sku to standard
AlexanderSehr May 17, 2022
67fbc2a
Added docs
AlexanderSehr May 17, 2022
fd02972
Update to latest
AlexanderSehr May 19, 2022
02c353d
small fix
AlexanderSehr May 19, 2022
4954a08
Updated PE ref
AlexanderSehr May 19, 2022
67fb5e4
merged latest main
AlexanderSehr May 20, 2022
c1abeeb
Updated readme
AlexanderSehr May 20, 2022
52bf930
Fixed diskEncryptionSet
AlexanderSehr May 20, 2022
7613e16
Update to latest
AlexanderSehr May 20, 2022
174bb8f
Fix
AlexanderSehr May 20, 2022
833fceb
Small fix
AlexanderSehr May 20, 2022
97ae4e5
Updated param
AlexanderSehr May 20, 2022
4018ab3
Adjusted VM deployment to reference nic
AlexanderSehr May 20, 2022
a0e9c5b
Small bugfix
AlexanderSehr May 20, 2022
5389346
Updated groupIds ref
AlexanderSehr May 20, 2022
fea7c14
Changed endpoint name
AlexanderSehr May 20, 2022
89d2757
Added PE test to sites
AlexanderSehr May 20, 2022
694f8aa
Fixed ref
AlexanderSehr May 20, 2022
7363152
Test different private link connection
AlexanderSehr May 20, 2022
f345732
Updated to original parmaeter files
AlexanderSehr May 20, 2022
5e31f01
Missing upload
AlexanderSehr May 20, 2022
4d446f4
Removed private endpoint from systemTopic
AlexanderSehr May 20, 2022
4c1f018
Fixed synapse
AlexanderSehr May 20, 2022
e44b5f5
Minor adjustment for NIC module
AlexanderSehr May 20, 2022
ae6d20d
Added groupID to name generation to avoid conflicts
AlexanderSehr May 20, 2022
4968cec
Added groupID to name generation to avoid conflicts
AlexanderSehr May 20, 2022
67725bc
Added sub domain to cognitive services to work with endpoints
AlexanderSehr May 20, 2022
b451f29
Added cognitive speech api example to deploy private endpoints
AlexanderSehr May 20, 2022
d8ac098
renamed file
AlexanderSehr May 20, 2022
0280529
Rename kvlt to work around conflict
AlexanderSehr May 20, 2022
732664b
Merge branch 'main' into users/alsehr/905_poc
AlexanderSehr May 20, 2022
e9688da
Updated app config
AlexanderSehr May 20, 2022
39e20d4
Updated readme
AlexanderSehr May 20, 2022
8420773
Merged latest main
AlexanderSehr May 21, 2022
e115bb6
Fixed resource names
AlexanderSehr May 21, 2022
c90727b
Simplification
AlexanderSehr May 21, 2022
ad8e607
Fixed param ref
AlexanderSehr May 21, 2022
3e7b978
Update to latest
AlexanderSehr May 21, 2022
77c6819
Update to latest
AlexanderSehr May 21, 2022
37023c4
Fixed typo
AlexanderSehr May 21, 2022
4d5ecb2
Update to latest
AlexanderSehr May 21, 2022
77a4081
Cleanup
AlexanderSehr May 21, 2022
79ad1d2
Updated resource naming
AlexanderSehr May 21, 2022
357c72d
Fixed readme
AlexanderSehr May 21, 2022
a4166ea
Update to the private endppint zone gen
AlexanderSehr May 23, 2022
80057a5
Update to latest
AlexanderSehr May 23, 2022
740fc93
Added output example
AlexanderSehr May 23, 2022
6cf3141
Added cross-module description
AlexanderSehr May 23, 2022
063f847
Update to latest
AlexanderSehr May 23, 2022
6fc010e
Update docs/wiki/The library - Module design.md
AlexanderSehr May 23, 2022
fccc84b
Fixed ref
AlexanderSehr May 23, 2022
173c900
Update to latest
AlexanderSehr May 23, 2022
d546a44
Merge branch 'main' of https://github.com/Azure/ResourceModules
AlexanderSehr May 24, 2022
edf083d
Updated PE parameter
AlexanderSehr May 24, 2022
51d558c
Merge branch 'main' of https://github.com/Azure/ResourceModules
AlexanderSehr May 25, 2022
577129f
Flipped image build deployment
AlexanderSehr May 25, 2022
e520258
Merge branch 'main' of https://github.com/Azure/ResourceModules
AlexanderSehr May 26, 2022
ba93d7a
Merge branch 'main' of https://github.com/Azure/ResourceModules
AlexanderSehr May 27, 2022
0c29aad
Update .azuredevops/modulePipelines/ms.cognitiveservices.accounts.yml
AlexanderSehr May 27, 2022
112e50f
Merged latest main
AlexanderSehr May 27, 2022
3a26718
Merge branch 'main' of https://github.com/Azure/ResourceModules
AlexanderSehr May 29, 2022
3564e81
Undid param change
AlexanderSehr May 29, 2022
4a27ee8
Merge branch 'main' of https://github.com/Azure/ResourceModules
AlexanderSehr May 29, 2022
077df54
Resolved conflicts
AlexanderSehr May 29, 2022
3f97aa9
Fixed readme pe ref
AlexanderSehr May 29, 2022
359f60e
Update arm/Microsoft.Compute/virtualMachines/.bicep/nested_networkInt…
AlexanderSehr May 29, 2022
fdddd24
Update arm/Microsoft.KeyVault/vaults/readme.md
AlexanderSehr May 29, 2022
3d77722
Update arm/Microsoft.Automation/automationAccounts/readme.md
AlexanderSehr May 29, 2022
5c8d9f4
Update arm/Microsoft.ServiceBus/namespaces/readme.md
AlexanderSehr May 29, 2022
dacaaf5
Update arm/Microsoft.EventHub/namespaces/readme.md
AlexanderSehr May 29, 2022
62c1276
Update docs/wiki/The library - Module design.md
AlexanderSehr May 29, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ stages:
removeDeployment: '${{ parameters.removeDeployment }}'
deploymentBlocks:
- path: $(modulePath)/.parameters/parameters.json
- path: $(modulePath)/.parameters/speech.parameters.json

- stage: Publishing
displayName: Publishing
Expand Down

This file was deleted.

22 changes: 16 additions & 6 deletions arm/Microsoft.AppConfiguration/configurationStores/deploy.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -188,13 +188,23 @@ module appConfiguration_rbac '.bicep/nested_rbac.bicep' = [for (roleAssignment,
}
}]

module appConfiguration_privateEndpoints '.bicep/nested_privateEndpoint.bicep' = [for (privateEndpoint, index) in privateEndpoints: {
name: '${uniqueString(deployment().name, location)}-AppConfig-PrivateEndpoint-${index}'
module appConfiguration_privateEndpoints '../../Microsoft.Network/privateEndpoints/deploy.bicep' = [for (privateEndpoint, index) in privateEndpoints: {
name: '${uniqueString(deployment().name, location)}-appConfiguration-PrivateEndpoint-${index}'
params: {
privateEndpointResourceId: appConfiguration.id
privateEndpointVnetLocation: empty(privateEndpoints) ? 'dummy' : reference(split(privateEndpoint.subnetResourceId, '/subnets/')[0], '2020-06-01', 'Full').location
privateEndpointObj: privateEndpoint
tags: tags
groupIds: [
privateEndpoint.service
]
name: contains(privateEndpoint, 'name') ? privateEndpoint.name : 'pe-${last(split(appConfiguration.id, '/'))}-${privateEndpoint.service}-${index}'
serviceResourceId: appConfiguration.id
subnetResourceId: privateEndpoint.subnetResourceId
enableDefaultTelemetry: enableDefaultTelemetry
location: reference(split(privateEndpoint.subnetResourceId, '/subnets/')[0], '2020-06-01', 'Full').location
lock: contains(privateEndpoint, 'lock') ? privateEndpoint.lock : 'NotSpecified'
privateDnsZoneGroups: contains(privateEndpoint, 'privateDnsZoneGroups') ? privateEndpoint.privateDnsZoneGroups : []
roleAssignments: contains(privateEndpoint, 'roleAssignments') ? privateEndpoint.roleAssignments : []
tags: contains(privateEndpoint, 'tags') ? privateEndpoint.tags : {}
manualPrivateLinkServiceConnections: contains(privateEndpoint, 'manualPrivateLinkServiceConnections') ? privateEndpoint.manualPrivateLinkServiceConnections : []
customDnsConfigs: contains(privateEndpoint, 'customDnsConfigs') ? privateEndpoint.customDnsConfigs : []
}
}]

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ This module deploys an App Configuration Store.
| `Microsoft.Authorization/roleAssignments` | [2020-10-01-preview](https://docs.microsoft.com/en-us/azure/templates/Microsoft.Authorization/2020-10-01-preview/roleAssignments) |
| `Microsoft.Insights/diagnosticSettings` | [2021-05-01-preview](https://docs.microsoft.com/en-us/azure/templates/Microsoft.Insights/2021-05-01-preview/diagnosticSettings) |
| `Microsoft.Network/privateEndpoints` | [2021-05-01](https://docs.microsoft.com/en-us/azure/templates/Microsoft.Network/2021-05-01/privateEndpoints) |
| `Microsoft.Network/privateEndpoints/privateDnsZoneGroups` | [2021-02-01](https://docs.microsoft.com/en-us/azure/templates/Microsoft.Network/2021-02-01/privateEndpoints/privateDnsZoneGroups) |
| `Microsoft.Network/privateEndpoints/privateDnsZoneGroups` | [2021-05-01](https://docs.microsoft.com/en-us/azure/templates/Microsoft.Network/2021-05-01/privateEndpoints/privateDnsZoneGroups) |

## Parameters

Expand Down Expand Up @@ -187,7 +187,6 @@ roleAssignments: [
</details>
<p>

=======
### Parameter Usage: `privateEndpoints`

To use Private Endpoint the following dependencies must be deployed:
Expand Down Expand Up @@ -265,7 +264,6 @@ privateEndpoints: [
</details>
<p>

>>>>>>> 3c13c7e234f0efcae26a25417453c58843d2002d
## Outputs

| Output Name | Type | Description |
Expand Down

This file was deleted.

22 changes: 16 additions & 6 deletions arm/Microsoft.Automation/automationAccounts/deploy.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -352,13 +352,23 @@ resource automationAccount_diagnosticSettings 'Microsoft.Insights/diagnosticSett
scope: automationAccount
}

module automationAccount_privateEndpoints '.bicep/nested_privateEndpoint.bicep' = [for (endpoint, index) in privateEndpoints: if (!empty(privateEndpoints)) {
name: '${uniqueString(deployment().name, location)}-AutoAccount-PrivateEndpoint-${index}'
module automationAccount_privateEndpoints '../../Microsoft.Network/privateEndpoints/deploy.bicep' = [for (privateEndpoint, index) in privateEndpoints: {
name: '${uniqueString(deployment().name, location)}-AutomationAccount-PrivateEndpoint-${index}'
params: {
privateEndpointResourceId: automationAccount.id
privateEndpointVnetLocation: !empty(privateEndpoints) ? reference(split(endpoint.subnetResourceId, '/subnets/')[0], '2020-06-01', 'Full').location : 'dummy'
privateEndpointObj: endpoint
tags: tags
groupIds: [
privateEndpoint.service
]
name: contains(privateEndpoint, 'name') ? privateEndpoint.name : 'pe-${last(split(automationAccount.id, '/'))}-${privateEndpoint.service}-${index}'
serviceResourceId: automationAccount.id
subnetResourceId: privateEndpoint.subnetResourceId
enableDefaultTelemetry: enableDefaultTelemetry
location: reference(split(privateEndpoint.subnetResourceId, '/subnets/')[0], '2020-06-01', 'Full').location
lock: contains(privateEndpoint, 'lock') ? privateEndpoint.lock : 'NotSpecified'
privateDnsZoneGroups: contains(privateEndpoint, 'privateDnsZoneGroups') ? privateEndpoint.privateDnsZoneGroups : []
roleAssignments: contains(privateEndpoint, 'roleAssignments') ? privateEndpoint.roleAssignments : []
tags: contains(privateEndpoint, 'tags') ? privateEndpoint.tags : {}
manualPrivateLinkServiceConnections: contains(privateEndpoint, 'manualPrivateLinkServiceConnections') ? privateEndpoint.manualPrivateLinkServiceConnections : []
customDnsConfigs: contains(privateEndpoint, 'customDnsConfigs') ? privateEndpoint.customDnsConfigs : []
}
}]

Expand Down
1 change: 0 additions & 1 deletion arm/Microsoft.Automation/automationAccounts/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,6 @@ userAssignedIdentities: {
"keyVersion" : {
"value" : "9917c14be51d4d93b37218de7d326f60"
},

"userAssignedIdentities": {
"value": {
"/subscriptions/<<subscriptionId>>/resourcegroups/validation-rg/providers/Microsoft.ManagedIdentity/userAssignedIdentities/adp-<<namePrefix>>-az-msi-x-001": {}
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
{
"$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentParameters.json#",
"contentVersion": "1.0.0.0",
"parameters": {
"name": {
"value": "<<namePrefix>>-az-cgs-speech-001"
},
"kind": {
"value": "SpeechServices"
},
"sku": {
"value": "F0"
},
"systemAssignedIdentity": {
"value": true
},
"userAssignedIdentities": {
"value": {
"/subscriptions/<<subscriptionId>>/resourcegroups/validation-rg/providers/Microsoft.ManagedIdentity/userAssignedIdentities/adp-<<namePrefix>>-az-msi-x-001": {}
}
},
"customSubDomainName": {
"value": "<<namePrefix>>domain"
},
"privateEndpoints": {
"value": [
{
"subnetResourceId": "/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.Network/virtualNetworks/adp-<<namePrefix>>-az-vnet-x-001/subnets/<<namePrefix>>-az-subnet-x-005-privateEndpoints",
"service": "account"
}
]
}
}
}
22 changes: 16 additions & 6 deletions arm/Microsoft.CognitiveServices/accounts/deploy.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ param diagnosticEventHubName string = ''
@description('Conditional. Subdomain name used for token-based authentication. Required if \'networkAcls\' are set.')
param customSubDomainName string = ''

@description('Optional. Subdomain name used for token-based authentication. Must be set if \'networkAcls\' are set.')
@description('Optional. Whether or not public endpoint access is allowed for this account.')
@allowed([
'Enabled'
'Disabled'
Expand Down Expand Up @@ -244,13 +244,23 @@ resource cognitiveServices_diagnosticSettingName 'Microsoft.Insights/diagnostics
scope: cognitiveServices
}

module cognitiveServices_privateEndpoints '.bicep/nested_privateEndpoints.bicep' = [for (privateEndpoint, index) in privateEndpoints: {
module cognitiveServices_privateEndpoints '../../Microsoft.Network/privateEndpoints/deploy.bicep' = [for (privateEndpoint, index) in privateEndpoints: {
name: '${uniqueString(deployment().name, location)}-CognitiveServices-PrivateEndpoint-${index}'
params: {
privateEndpointResourceId: cognitiveServices.id
privateEndpointVnetLocation: (empty(privateEndpoints) ? 'dummy' : reference(split(privateEndpoint.subnetResourceId, '/subnets/')[0], '2020-06-01', 'Full').location)
privateEndpoint: privateEndpoint
tags: tags
groupIds: [
privateEndpoint.service
]
name: contains(privateEndpoint, 'name') ? privateEndpoint.name : 'pe-${last(split(cognitiveServices.id, '/'))}-${privateEndpoint.service}-${index}'
serviceResourceId: cognitiveServices.id
subnetResourceId: privateEndpoint.subnetResourceId
enableDefaultTelemetry: enableDefaultTelemetry
location: reference(split(privateEndpoint.subnetResourceId, '/subnets/')[0], '2020-06-01', 'Full').location
lock: contains(privateEndpoint, 'lock') ? privateEndpoint.lock : 'NotSpecified'
privateDnsZoneGroups: contains(privateEndpoint, 'privateDnsZoneGroups') ? privateEndpoint.privateDnsZoneGroups : []
roleAssignments: contains(privateEndpoint, 'roleAssignments') ? privateEndpoint.roleAssignments : []
tags: contains(privateEndpoint, 'tags') ? privateEndpoint.tags : {}
manualPrivateLinkServiceConnections: contains(privateEndpoint, 'manualPrivateLinkServiceConnections') ? privateEndpoint.manualPrivateLinkServiceConnections : []
customDnsConfigs: contains(privateEndpoint, 'customDnsConfigs') ? privateEndpoint.customDnsConfigs : []
}
}]

Expand Down
Loading