-
Notifications
You must be signed in to change notification settings - Fork 437
[Modules] Cross-Module references #1401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
89 commits
Select commit
Hold shift + click to select a range
ca89185
Updated private endpoint default + cross referenced it from kvlt
AlexanderSehr 8714b57
Updated more private endpoint references
AlexanderSehr 84af966
Updated further endpoints
AlexanderSehr 73c7eae
Updated VM
AlexanderSehr 986334b
Further reducation
AlexanderSehr 07df868
Further updates
AlexanderSehr 22b6dde
Update to latest
AlexanderSehr a7afd0c
Update to latest
AlexanderSehr dd02fc0
Update to latest
AlexanderSehr c0f6e9d
Moved protected item
AlexanderSehr e76caac
Minor fi
AlexanderSehr e6e8acf
Update to latest
AlexanderSehr b3f8964
Fixed missing check
AlexanderSehr 2d427e3
Resolved conflicts
AlexanderSehr 8b4b324
Update to latest
AlexanderSehr 9a5c593
Updated readme
AlexanderSehr 2e6a846
Minor fix
AlexanderSehr c9e4a54
Adjusted name gen to original
AlexanderSehr 0b0485f
Changed pip sku to standard
AlexanderSehr 67fbc2a
Added docs
AlexanderSehr fd02972
Update to latest
AlexanderSehr 02c353d
small fix
AlexanderSehr 4954a08
Updated PE ref
AlexanderSehr 67fb5e4
merged latest main
AlexanderSehr c1abeeb
Updated readme
AlexanderSehr 52bf930
Fixed diskEncryptionSet
AlexanderSehr 7613e16
Update to latest
AlexanderSehr 174bb8f
Fix
AlexanderSehr 833fceb
Small fix
AlexanderSehr 97ae4e5
Updated param
AlexanderSehr 4018ab3
Adjusted VM deployment to reference nic
AlexanderSehr a0e9c5b
Small bugfix
AlexanderSehr 5389346
Updated groupIds ref
AlexanderSehr fea7c14
Changed endpoint name
AlexanderSehr 89d2757
Added PE test to sites
AlexanderSehr 694f8aa
Fixed ref
AlexanderSehr 7363152
Test different private link connection
AlexanderSehr f345732
Updated to original parmaeter files
AlexanderSehr 5e31f01
Missing upload
AlexanderSehr 4d446f4
Removed private endpoint from systemTopic
AlexanderSehr 4c1f018
Fixed synapse
AlexanderSehr e44b5f5
Minor adjustment for NIC module
AlexanderSehr ae6d20d
Added groupID to name generation to avoid conflicts
AlexanderSehr 4968cec
Added groupID to name generation to avoid conflicts
AlexanderSehr 67725bc
Added sub domain to cognitive services to work with endpoints
AlexanderSehr b451f29
Added cognitive speech api example to deploy private endpoints
AlexanderSehr d8ac098
renamed file
AlexanderSehr 0280529
Rename kvlt to work around conflict
AlexanderSehr 732664b
Merge branch 'main' into users/alsehr/905_poc
AlexanderSehr e9688da
Updated app config
AlexanderSehr 39e20d4
Updated readme
AlexanderSehr 8420773
Merged latest main
AlexanderSehr e115bb6
Fixed resource names
AlexanderSehr c90727b
Simplification
AlexanderSehr ad8e607
Fixed param ref
AlexanderSehr 3e7b978
Update to latest
AlexanderSehr 77c6819
Update to latest
AlexanderSehr 37023c4
Fixed typo
AlexanderSehr 4d5ecb2
Update to latest
AlexanderSehr 77a4081
Cleanup
AlexanderSehr 79ad1d2
Updated resource naming
AlexanderSehr 357c72d
Fixed readme
AlexanderSehr a4166ea
Update to the private endppint zone gen
AlexanderSehr 80057a5
Update to latest
AlexanderSehr 740fc93
Added output example
AlexanderSehr 6cf3141
Added cross-module description
AlexanderSehr 063f847
Update to latest
AlexanderSehr 6fc010e
Update docs/wiki/The library - Module design.md
AlexanderSehr fccc84b
Fixed ref
AlexanderSehr 173c900
Update to latest
AlexanderSehr d546a44
Merge branch 'main' of https://github.com/Azure/ResourceModules
AlexanderSehr edf083d
Updated PE parameter
AlexanderSehr 51d558c
Merge branch 'main' of https://github.com/Azure/ResourceModules
AlexanderSehr 577129f
Flipped image build deployment
AlexanderSehr e520258
Merge branch 'main' of https://github.com/Azure/ResourceModules
AlexanderSehr ba93d7a
Merge branch 'main' of https://github.com/Azure/ResourceModules
AlexanderSehr 0c29aad
Update .azuredevops/modulePipelines/ms.cognitiveservices.accounts.yml
AlexanderSehr 112e50f
Merged latest main
AlexanderSehr 3a26718
Merge branch 'main' of https://github.com/Azure/ResourceModules
AlexanderSehr 3564e81
Undid param change
AlexanderSehr 4a27ee8
Merge branch 'main' of https://github.com/Azure/ResourceModules
AlexanderSehr 077df54
Resolved conflicts
AlexanderSehr 3f97aa9
Fixed readme pe ref
AlexanderSehr 359f60e
Update arm/Microsoft.Compute/virtualMachines/.bicep/nested_networkInt…
AlexanderSehr fdddd24
Update arm/Microsoft.KeyVault/vaults/readme.md
AlexanderSehr 3d77722
Update arm/Microsoft.Automation/automationAccounts/readme.md
AlexanderSehr 5c8d9f4
Update arm/Microsoft.ServiceBus/namespaces/readme.md
AlexanderSehr dacaaf5
Update arm/Microsoft.EventHub/namespaces/readme.md
AlexanderSehr 62c1276
Update docs/wiki/The library - Module design.md
AlexanderSehr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 0 additions & 49 deletions
49
arm/Microsoft.AppConfiguration/configurationStores/.bicep/nested_privateEndpoint.bicep
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 0 additions & 52 deletions
52
arm/Microsoft.Automation/automationAccounts/.bicep/nested_privateEndpoint.bicep
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 0 additions & 49 deletions
49
arm/Microsoft.CognitiveServices/accounts/.bicep/nested_privateEndpoints.bicep
This file was deleted.
Oops, something went wrong.
34 changes: 34 additions & 0 deletions
34
arm/Microsoft.CognitiveServices/accounts/.parameters/speech.parameters.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| { | ||
| "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentParameters.json#", | ||
| "contentVersion": "1.0.0.0", | ||
| "parameters": { | ||
| "name": { | ||
| "value": "<<namePrefix>>-az-cgs-speech-001" | ||
| }, | ||
| "kind": { | ||
| "value": "SpeechServices" | ||
| }, | ||
| "sku": { | ||
| "value": "F0" | ||
| }, | ||
| "systemAssignedIdentity": { | ||
| "value": true | ||
| }, | ||
| "userAssignedIdentities": { | ||
| "value": { | ||
| "/subscriptions/<<subscriptionId>>/resourcegroups/validation-rg/providers/Microsoft.ManagedIdentity/userAssignedIdentities/adp-<<namePrefix>>-az-msi-x-001": {} | ||
| } | ||
| }, | ||
| "customSubDomainName": { | ||
| "value": "<<namePrefix>>domain" | ||
| }, | ||
| "privateEndpoints": { | ||
| "value": [ | ||
| { | ||
| "subnetResourceId": "/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.Network/virtualNetworks/adp-<<namePrefix>>-az-vnet-x-001/subnets/<<namePrefix>>-az-subnet-x-005-privateEndpoints", | ||
| "service": "account" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.